shuffle around mock version to centralized location to fix dependabot PR#3084
Conversation
derrickaw
commented
Dec 9, 2025
- Fix dependabot PR - build(deps-dev): bump mock-server-netty.version from 5.14.0 to 5.15.0 #2865 as it missed the mock server version in a different pom.
- Move the mock server version to the parent pom and then reference that for both locations.
- Also, fix a small alphabetical sorting issue for properties.
Summary of ChangesHello @derrickaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the management of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request successfully centralizes the mock-server dependency version into the parent pom.xml and updates it. This resolves an inconsistency and improves maintainability. The changes also correct the alphabetical sorting of properties in the parent POM. The implementation is correct and follows best practices for Maven project management.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3084 +/- ##
============================================
- Coverage 50.41% 50.38% -0.03%
- Complexity 5022 5395 +373
============================================
Files 970 970
Lines 59606 59606
Branches 6506 6506
============================================
- Hits 30051 30034 -17
- Misses 27434 27447 +13
- Partials 2121 2125 +4
🚀 New features to boost your workflow:
|