Skip to content

shuffle around mock version to centralized location to fix dependabot PR#3084

Merged
derrickaw merged 1 commit intoGoogleCloudPlatform:mainfrom
derrickaw:fixMockServerDependabotPR
Dec 9, 2025
Merged

shuffle around mock version to centralized location to fix dependabot PR#3084
derrickaw merged 1 commit intoGoogleCloudPlatform:mainfrom
derrickaw:fixMockServerDependabotPR

Conversation

@derrickaw
Copy link
Contributor

  1. Fix dependabot PR - build(deps-dev): bump mock-server-netty.version from 5.14.0 to 5.15.0 #2865 as it missed the mock server version in a different pom.
  2. Move the mock server version to the parent pom and then reference that for both locations.
  3. Also, fix a small alphabetical sorting issue for properties.

@gemini-code-assist
Copy link

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the management of the mock-server dependency version by centralizing it in the parent pom.xml. This change resolves a previous Dependabot issue where a module was not correctly picking up the updated version, ensuring consistent dependency management across the project. Additionally, it includes an update to the mock-server version and a minor cleanup of property sorting.

Highlights

  • Dependency Version Centralization: The mock-server-netty.version property has been moved from v1/pom.xml to the parent pom.xml to centralize its definition.
  • Dependabot PR Fix: This change addresses a Dependabot PR issue by ensuring the mockserver-client-java dependency in it/datadog/pom.xml correctly references the centralized version property.
  • Version Update: The mock-server-netty.version has been updated to 5.15.0 in the parent pom.xml.
  • Property Sorting: A minor alphabetical sorting issue for properties within the parent pom.xml has been corrected.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@derrickaw
Copy link
Contributor Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully centralizes the mock-server dependency version into the parent pom.xml and updates it. This resolves an inconsistency and improves maintainability. The changes also correct the alphabetical sorting of properties in the parent POM. The implementation is correct and follows best practices for Maven project management.

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.38%. Comparing base (301cd41) to head (c1f6443).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3084      +/-   ##
============================================
- Coverage     50.41%   50.38%   -0.03%     
- Complexity     5022     5395     +373     
============================================
  Files           970      970              
  Lines         59606    59606              
  Branches       6506     6506              
============================================
- Hits          30051    30034      -17     
- Misses        27434    27447      +13     
- Partials       2121     2125       +4     
Components Coverage Δ
spanner-templates 70.59% <ø> (-0.07%) ⬇️
spanner-import-export 68.84% <ø> (-0.17%) ⬇️
spanner-live-forward-migration 80.03% <ø> (ø)
spanner-live-reverse-replication 77.46% <ø> (ø)
spanner-bulk-migration 88.25% <ø> (ø)
see 7 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw derrickaw merged commit d5fb593 into GoogleCloudPlatform:main Dec 9, 2025
50 of 52 checks passed
@derrickaw derrickaw deleted the fixMockServerDependabotPR branch December 9, 2025 17:38
aasthabharill pushed a commit to aasthabharill/DataflowTemplates that referenced this pull request Dec 15, 2025
aasthabharill pushed a commit to aasthabharill/DataflowTemplates that referenced this pull request Dec 17, 2025
MnkyGns pushed a commit to MnkyGns/DataflowTemplates that referenced this pull request Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants