Skip to content

Fix Auto Generate script to consider option files#3088

Merged
tarun-google merged 2 commits intoGoogleCloudPlatform:mainfrom
tarun-google:fix_script
Dec 10, 2025
Merged

Fix Auto Generate script to consider option files#3088
tarun-google merged 2 commits intoGoogleCloudPlatform:mainfrom
tarun-google:fix_script

Conversation

@tarun-google
Copy link
Contributor

@tarun-google tarun-google commented Dec 9, 2025

  1. Extended Template Auto Generation script to fetch options from files
  2. Updated PostgresToIceberg YAML Template with the Auto generate script
Screenshot 2025-12-09 at 2 06 05 PM

@gemini-code-assist
Copy link

Summary of Changes

Hello @tarun-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the flexibility and maintainability of template definitions by enabling the auto-generation script to read parameters from external option files. This change allows for better organization and reuse of common parameter sets across different templates. Concurrently, the PostgresToIceberg template has been updated to utilize this new feature and refine its parameter configurations, ensuring consistency and clarity.

Highlights

  • Enhanced Template Auto-Generation: The script responsible for auto-generating Java templates from YAML definitions has been extended to now fetch and incorporate options defined in separate YAML files, improving modularity and reusability of parameter definitions.
  • Updated PostgresToIceberg Template: The PostgresToIceberg YAML template has been updated to leverage the new option file functionality and includes several refinements to its parameter definitions, such as marking certain parameters as required and updating descriptions.
  • New Parameter Types Supported: The auto-generation script now supports additional parameter types including map, enum, and password, allowing for more expressive and secure template definitions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@derrickaw
Copy link
Contributor

Can you run that script on the KafkaToBigQuery.yaml and verify everything looks good and include the changes in this PR. Thanks.

@tarun-google tarun-google requested a review from Abacn December 9, 2025 22:06
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.39%. Comparing base (301cd41) to head (d7b777f).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3088      +/-   ##
============================================
- Coverage     50.41%   50.39%   -0.02%     
+ Complexity     5022     5019       -3     
============================================
  Files           970      970              
  Lines         59606    59609       +3     
  Branches       6506     6507       +1     
============================================
- Hits          30051    30042       -9     
- Misses        27434    27441       +7     
- Partials       2121     2126       +5     
Components Coverage Δ
spanner-templates 70.62% <ø> (-0.03%) ⬇️
spanner-import-export 68.98% <ø> (-0.03%) ⬇️
spanner-live-forward-migration 80.01% <ø> (-0.02%) ⬇️
spanner-live-reverse-replication 77.40% <ø> (-0.07%) ⬇️
spanner-bulk-migration 88.24% <ø> (-0.02%) ⬇️
see 5 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw derrickaw added improvement Making existing code better bug-fix labels Dec 10, 2025
@tarun-google tarun-google merged commit 63f929d into GoogleCloudPlatform:main Dec 10, 2025
15 of 16 checks passed
aasthabharill pushed a commit to aasthabharill/DataflowTemplates that referenced this pull request Dec 15, 2025
…m#3088)

* Fix Auto Generate script to consider option files

* make YAML public
aasthabharill pushed a commit to aasthabharill/DataflowTemplates that referenced this pull request Dec 17, 2025
…m#3088)

* Fix Auto Generate script to consider option files

* make YAML public
MnkyGns pushed a commit to MnkyGns/DataflowTemplates that referenced this pull request Feb 12, 2026
…m#3088)

* Fix Auto Generate script to consider option files

* make YAML public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix improvement Making existing code better size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants