Spanner bulk data migration: Add support for DECIMAL as a primary key#3119
Conversation
…littability checks
Summary of ChangesHello @nmemond, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces robust support for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3119 +/- ##
============================================
+ Coverage 50.54% 55.88% +5.34%
+ Complexity 5047 1642 -3405
============================================
Files 974 471 -503
Lines 59808 26523 -33285
Branches 6523 2781 -3742
============================================
- Hits 30230 14823 -15407
+ Misses 27443 10802 -16641
+ Partials 2135 898 -1237
🚀 New features to boost your workflow:
|
.../java/com/google/cloud/teleport/v2/source/reader/io/jdbc/uniformsplitter/range/Boundary.java
Show resolved
Hide resolved
...e/cloud/teleport/v2/source/reader/io/jdbc/uniformsplitter/range/BoundarySplitterFactory.java
Outdated
Show resolved
Hide resolved
|
Please rebase This PR on top of the tree code. |
…GoogleCloudPlatform#3119) * add DECIMAL type support as primary key * fix spotless error * Update MysqlDialectAdapterTest.java * fix spotless * add DECIMAL PK with precision/scale * update BigDecimal splitter to handle scale correctly * Add BigDecimal boundary splitter with precision-aware equality and splittability checks * Fix DECIMAL type mapping to use BigDecimal splitter * Support DECIMAL columns with precision-aware splitting * Fix compilation issues and test failures * Address PR feedback --------- Co-authored-by: gpalanisamyYopp <gayathri.palanisamy@improving.com>
This is a copy of #3087 but up-to-date with main and with issues fixed, because that developer is out of office for the rest of the year and I don't have permissions to push to their fork.