Fix flaky SpannerToMySqlCustomTransformationLT.reverseReplication1KTpsWithCustomTransformation

[aasthabharill]

https://b.corp.google.com/issues/466418780

Logs:

In Github Run Logs you can see:

03:25:04.088 [main] INFO o.a.b.it.conditions.ConditionCheck - [?] Checking for condition 'JDBC database check if table Person has between 300000 and 300000 rows'...
03:25:05.478 [main] INFO o.a.b.it.conditions.ConditionCheck - [✗] Condition 'JDBC database check if table Person has between 300000 and 300000 rows' not met! Expected 300000 rows but has only 295033

03:25:35.797 [main] INFO o.a.b.it.conditions.ConditionCheck - [?] Checking for condition 'JDBC database check if table Person has between 300000 and 300000 rows'...
03:25:37.412 [main] INFO o.a.b.it.conditions.ConditionCheck - [✗] Condition 'JDBC database check if table Person has between 300000 and 300000 rows' not met! Expected 300000 rows but has only 296579

03:26:07.729 [main] INFO o.a.b.it.conditions.ConditionCheck - [?] Checking for condition 'JDBC database check if table Person has between 300000 and 300000 rows'...
03:26:09.244 [main] INFO o.a.b.it.conditions.ConditionCheck - [✗] Condition 'JDBC database check if table Person has between 300000 and 300000 rows' not met! Expected 300000 rows but has only 297836

RCA:

The row count is steadily increasing but the test times out before it reaches the target of 300k rows. This seems like a timeout issue.

Fix:

Update timeout from 10 mins to 12 mins

[gemini-code-assist]

Summary of Changes

Hello @aasthabharill, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a reported flakiness issue in the SpannerToMySqlCustomTransformationLT integration test. By increasing the waiting period for a specific condition, the change ensures that the test has adequate time to complete its operations, thereby preventing intermittent failures and contributing to a more robust and stable testing environment.

Highlights

• Test Stability Improvement: The waitForCondition timeout in the reverseReplication1KTpsWithCustomTransformation test has been extended from 10 minutes to 12 minutes to address flakiness and improve test reliability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.68%. Comparing base (08838cc) to head (aedb6b9).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3135      +/-   ##
============================================
+ Coverage     50.66%   50.68%   +0.02%     
- Complexity     5051     5069      +18     
============================================
  Files           974      974              
  Lines         59828    59872      +44     
  Branches       6527     6536       +9     
============================================
+ Hits          30314    30349      +35     
- Misses        27370    27380      +10     
+ Partials       2144     2143       -1     

Components	Coverage Δ
spanner-templates	70.82% <ø> (+0.01%)	⬆️
spanner-import-export	68.85% <ø> (-0.12%)	⬇️
spanner-live-forward-migration	80.06% <ø> (+0.01%)	⬆️
spanner-live-reverse-replication	77.74% <ø> (+0.01%)	⬆️
spanner-bulk-migration	88.35% <ø> (+0.06%)	⬆️
see 12 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.