-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Iam test #3138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pratickchokhani
wants to merge
2
commits into
GoogleCloudPlatform:main
Choose a base branch
from
pratickchokhani:iam_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Iam test #3138
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
v1/src/main/java/com/google/cloud/teleport/spanner/iam/IAMCheckResult.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Copyright (C) 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package com.google.cloud.teleport.spanner.iam; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| /** Represents the result of an IAM permission check on a specific resource. */ | ||
| public class IAMCheckResult { | ||
| private final String resourceName; | ||
| private final List<String> missingPermissions; | ||
|
|
||
| public IAMCheckResult(String resourceName, List<String> missingPermissions) { | ||
| this.resourceName = resourceName; | ||
| this.missingPermissions = new ArrayList<>(missingPermissions); | ||
| } | ||
|
|
||
| public String getResourceName() { | ||
| return resourceName; | ||
| } | ||
|
|
||
| public List<String> getMissingPermissions() { | ||
| return new ArrayList<>(missingPermissions); | ||
| } | ||
|
|
||
| public boolean isPermissionsAvailable() { | ||
| return missingPermissions.isEmpty(); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "IAMCheckResult{" | ||
| + "resourceName='" | ||
| + resourceName | ||
| + '\'' | ||
| + ", missingPermissions=" | ||
| + missingPermissions | ||
| + ", success=" | ||
| + isPermissionsAvailable() | ||
| + '}'; | ||
| } | ||
| } |
102 changes: 102 additions & 0 deletions
102
v1/src/main/java/com/google/cloud/teleport/spanner/iam/IAMPermissionsChecker.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| /* | ||
| * Copyright (C) 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package com.google.cloud.teleport.spanner.iam; | ||
|
|
||
| import com.google.cloud.spanner.DatabaseNotFoundException; | ||
| import com.google.cloud.spanner.Spanner; | ||
| import com.google.cloud.spanner.SpannerOptions; | ||
| import com.google.common.annotations.VisibleForTesting; | ||
| import java.io.IOException; | ||
| import java.security.GeneralSecurityException; | ||
| import java.util.HashSet; | ||
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
| import java.util.stream.StreamSupport; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** Utility to check IAM permissions for various GCP resources. */ | ||
| public class IAMPermissionsChecker { | ||
| private static final Logger LOG = LoggerFactory.getLogger(IAMPermissionsChecker.class); | ||
| private final String projectId; | ||
|
|
||
| private final Spanner spanner; | ||
| private static final String INSTANCE_STRING = "projects/%s/instances/%s"; | ||
| private static final String DATABASE_STRING = "projects/%s/instances/%s/database/%s"; | ||
|
|
||
| public IAMPermissionsChecker(String projectId) throws GeneralSecurityException, IOException { | ||
| SpannerOptions options = SpannerOptions.newBuilder().setProjectId(projectId).build(); | ||
|
|
||
| this.spanner = options.getService(); | ||
| this.projectId = projectId; | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| IAMPermissionsChecker(Spanner spanner, String projectId) { | ||
| this.projectId = projectId; | ||
| this.spanner = spanner; | ||
| } | ||
|
|
||
| /** | ||
| * Checks IAM permissions for a list of requirements. This api should be called once with all the | ||
| * requirements. | ||
| * | ||
| * @return List of results, only missing permissions are included. Empty list indicate all the | ||
| * requirements are met. | ||
| */ | ||
| public IAMCheckResult checkSpannerInstanceRequirements( | ||
| List<String> permissionList, String instanceId) { | ||
|
|
||
| Iterable<String> grantedPermissions = | ||
| spanner.getInstanceAdminClient().getInstance(instanceId).testIAMPermissions(permissionList); | ||
|
|
||
| return new IAMCheckResult( | ||
| String.format(INSTANCE_STRING, projectId, instanceId), | ||
| fetchMissingPermission(permissionList, grantedPermissions)); | ||
| } | ||
|
|
||
| /** | ||
| * Checks IAM permissions for a list of requirements. This api should be called once with all the | ||
| * requirements. | ||
| * | ||
| * @return List of results, only missing permissions are included. Empty list indicate all the | ||
| * requirements are met. | ||
| * @throws DatabaseNotFoundException when database is not found. | ||
| */ | ||
| public IAMCheckResult checkSpannerDatabaseRequirements( | ||
| List<String> permissionList, String instanceId, String databaseId) | ||
| throws DatabaseNotFoundException { | ||
|
|
||
| Iterable<String> grantedPermissions = | ||
| spanner | ||
| .getDatabaseAdminClient() | ||
| .getDatabase(instanceId, databaseId) | ||
| .testIAMPermissions(permissionList); | ||
| return new IAMCheckResult( | ||
| String.format(DATABASE_STRING, projectId, instanceId, databaseId), | ||
| fetchMissingPermission(permissionList, grantedPermissions)); | ||
| } | ||
|
|
||
| private List<String> fetchMissingPermission( | ||
| List<String> requiredPermission, Iterable<String> grantedPermissions) { | ||
|
|
||
| HashSet<String> grantedPermissionsSet = | ||
| StreamSupport.stream(grantedPermissions.spliterator(), false) | ||
| .collect(Collectors.toCollection(HashSet::new)); | ||
|
|
||
| return requiredPermission.stream().filter(p -> !grantedPermissionsSet.contains(p)).toList(); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This validation will happen after the pipeline starts, which is going to be pretty similar to running the import itself.