Increasing maxConnection on MySqlResourceManager For AllDataTypesIT#3147
Conversation
Summary of ChangesHello @VardhanThigle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a configuration adjustment for the MySQL database used in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3147 +/- ##
============================================
+ Coverage 50.71% 56.12% +5.41%
+ Complexity 5084 1693 -3391
============================================
Files 974 471 -503
Lines 59904 26662 -33242
Branches 6543 2805 -3738
============================================
- Hits 30379 14965 -15414
+ Misses 27380 10800 -16580
+ Partials 2145 897 -1248
🚀 New features to boost your workflow:
|
IT only Change - Increasing maxConnection on Containarized MySqlResourceManager For AllDataTypesIT, this is to unblock #3046 which is adding more schema elements to AllDataTypesIT for cross Schema Testing thereby opening more connection to the container (active connections = O(tables)).
TODO: Waiting for IT run to check if this works.