Skip to content

Conversation

@TanuSharma2511
Copy link
Contributor

Integration test job: 2025-12-31_18_59_01-5972787476438340316

@gemini-code-assist
Copy link

Summary of Changes

Hello @TanuSharma2511, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Dataflow Flex Template, SqlServerToIceberg (YAML), designed to facilitate batch data transfer from SQL Server databases to Iceberg tables. The template provides a comprehensive set of configurable parameters for both source (SQL Server) and destination (Iceberg), enabling users to define connection details, data extraction queries, and Iceberg table properties. This addition enhances the template library by offering a direct, configurable solution for migrating data from SQL Server to Iceberg within the Dataflow ecosystem.

Highlights

  • New YAML Blueprint: A new YAML blueprint named SqlServerToIceberg (YAML) has been added, enabling batch data transfer from SQL Server to Iceberg tables.
  • Comprehensive Parameterization: The template includes extensive parameters for JDBC connection details (URL, username, password, driver), SQL Server read configurations (query, partitioning, fetch size), and Iceberg write options (table, catalog, properties, field transformations).
  • Documentation and Testing: Dedicated documentation (README_SqlServer_To_Iceberg_Yaml.md) and integration tests (SqlServerToIcebergYamlIT.java) have been added to support and validate the new template's functionality.
  • Dependency Update: The pom.xml file has been updated to include the mssql-jdbc dependency, ensuring proper connectivity for SQL Server operations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@TanuSharma2511
Copy link
Contributor Author

R: @derrickaw
R: @tarun-google

Copy link
Contributor

@derrickaw derrickaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anowardear062-svg
Copy link

I am very happy

@derrickaw derrickaw added addition New feature or request improvement labels Jan 2, 2026
@TanuSharma2511 TanuSharma2511 requested a review from a team as a code owner January 6, 2026 07:49
@TanuSharma2511
Copy link
Contributor Author

@tarun-google I have resolved the comments.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.80%. Comparing base (3a6e719) to head (ccbce64).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3175   +/-   ##
=========================================
  Coverage     50.79%   50.80%           
- Complexity     5122     5124    +2     
=========================================
  Files           976      976           
  Lines         60058    60058           
  Branches       6569     6569           
=========================================
+ Hits          30509    30510    +1     
+ Misses        27407    27406    -1     
  Partials       2142     2142           
Components Coverage Δ
spanner-templates 71.00% <ø> (-0.01%) ⬇️
spanner-import-export 68.99% <ø> (+0.02%) ⬆️
spanner-live-forward-migration 80.08% <ø> (-0.02%) ⬇️
spanner-live-reverse-replication 77.71% <ø> (-0.07%) ⬇️
spanner-bulk-migration 88.43% <ø> (-0.02%) ⬇️
see 5 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw
Copy link
Contributor

Run mvn spotless:apply to fix that check failure. Thanks

@TanuSharma2511
Copy link
Contributor Author

Run mvn spotless:apply to fix that check failure. Thanks

Done. Thanks.

@derrickaw
Copy link
Contributor

The Checkstyle failure is an on-going issue that is not caused by your PR. Need to sit tight until that is resolved first. Otherwise LGTM. Thanks.

@derrickaw derrickaw merged commit c1bb9ef into GoogleCloudPlatform:main Jan 7, 2026
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants