Skip to content

add yaml manifest file#3227

Merged
chamikaramj merged 7 commits intoGoogleCloudPlatform:mainfrom
derrickaw:addManifestFile
Jan 31, 2026
Merged

add yaml manifest file#3227
chamikaramj merged 7 commits intoGoogleCloudPlatform:mainfrom
derrickaw:addManifestFile

Conversation

@derrickaw
Copy link
Contributor

  1. add yaml manifest file
  2. group gson dependency and update to non-vulnerability of 2.13.2

@gemini-code-assist
Copy link

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new capability to automatically generate and upload a YAML manifest file to Google Cloud Storage during the template release process. This manifest will serve as a centralized index for all deployed YAML blueprints, improving discoverability and management. Concurrently, it refactors the gson dependency management across the project, centralizing its version definition and upgrading it to a more secure version.

Highlights

  • YAML Manifest Generation: A new feature has been added to generate a yaml-manifest.json file during the release process. This manifest will list all uploaded YAML blueprints, including their names and Google Cloud Storage (GCS) paths, improving discoverability and management.
  • GSON Dependency Update and Centralization: The gson dependency version has been centralized in the root pom.xml and updated from 2.9.1 to 2.13.2 to address known vulnerabilities and streamline dependency management across the project.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@derrickaw derrickaw added the improvement Making existing code better label Jan 16, 2026
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.02%. Comparing base (18ea97b) to head (f4cc4f7).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...ud/teleport/plugin/maven/TemplatesReleaseMojo.java 88.88% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3227      +/-   ##
============================================
+ Coverage     50.93%   51.02%   +0.08%     
- Complexity     5159     5546     +387     
============================================
  Files           977      978       +1     
  Lines         60351    60419      +68     
  Branches       6596     6616      +20     
============================================
+ Hits          30740    30827      +87     
+ Misses        27461    27433      -28     
- Partials       2150     2159       +9     
Components Coverage Δ
spanner-templates 70.88% <ø> (-0.17%) ⬇️
spanner-import-export 69.01% <ø> (-0.08%) ⬇️
spanner-live-forward-migration 80.04% <ø> (-0.08%) ⬇️
spanner-live-reverse-replication 77.63% <ø> (-0.10%) ⬇️
spanner-bulk-migration 88.08% <ø> (-0.38%) ⬇️
Files with missing lines Coverage Δ
...ud/teleport/plugin/maven/TemplatesReleaseMojo.java 62.10% <88.88%> (+15.26%) ⬆️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw
Copy link
Contributor Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the generation of a yaml-manifest.json file when publishing YAML blueprints and updates the gson dependency to version 2.13.2 to address a vulnerability. The changes are well-implemented, and the new functionality is covered by a comprehensive test. I have a few suggestions for improvement regarding code style and best practices, which I've detailed in the comments. Overall, this is a good contribution.

@derrickaw derrickaw marked this pull request as ready for review January 17, 2026 02:54
@derrickaw derrickaw requested a review from chamikaramj January 21, 2026 19:30
Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM other than two minor comments.

@derrickaw derrickaw requested a review from chamikaramj January 28, 2026 20:29
@derrickaw
Copy link
Contributor Author

R: @chamikaramj

@chamikaramj
Copy link
Contributor

LGTM. Thanks!

@chamikaramj chamikaramj merged commit bce4e4a into GoogleCloudPlatform:main Jan 31, 2026
68 of 71 checks passed
@derrickaw derrickaw deleted the addManifestFile branch January 31, 2026 02:42
Abacn added a commit that referenced this pull request Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants