add yaml manifest file#3227
Conversation
derrickaw
commented
Jan 16, 2026
- add yaml manifest file
- group gson dependency and update to non-vulnerability of 2.13.2
Summary of ChangesHello @derrickaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new capability to automatically generate and upload a YAML manifest file to Google Cloud Storage during the template release process. This manifest will serve as a centralized index for all deployed YAML blueprints, improving discoverability and management. Concurrently, it refactors the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3227 +/- ##
============================================
+ Coverage 50.93% 51.02% +0.08%
- Complexity 5159 5546 +387
============================================
Files 977 978 +1
Lines 60351 60419 +68
Branches 6596 6616 +20
============================================
+ Hits 30740 30827 +87
+ Misses 27461 27433 -28
- Partials 2150 2159 +9
🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces the generation of a yaml-manifest.json file when publishing YAML blueprints and updates the gson dependency to version 2.13.2 to address a vulnerability. The changes are well-implemented, and the new functionality is covered by a comprehensive test. I have a few suggestions for improvement regarding code style and best practices, which I've detailed in the comments. Overall, this is a good contribution.
...-maven-plugin/src/main/java/com/google/cloud/teleport/plugin/maven/TemplatesReleaseMojo.java
Outdated
Show resolved
Hide resolved
...-maven-plugin/src/main/java/com/google/cloud/teleport/plugin/maven/TemplatesReleaseMojo.java
Outdated
Show resolved
Hide resolved
...en-plugin/src/test/java/com/google/cloud/teleport/plugin/maven/TemplatesReleaseMojoTest.java
Outdated
Show resolved
Hide resolved
6fbac6b to
468d1ab
Compare
...-maven-plugin/src/main/java/com/google/cloud/teleport/plugin/maven/TemplatesReleaseMojo.java
Outdated
Show resolved
Hide resolved
chamikaramj
left a comment
There was a problem hiding this comment.
Thanks. LGTM other than two minor comments.
...-maven-plugin/src/main/java/com/google/cloud/teleport/plugin/maven/TemplatesReleaseMojo.java
Outdated
Show resolved
Hide resolved
|
R: @chamikaramj |
|
LGTM. Thanks! |