Skip to content

Addressing comments

826933f
Select commit
Loading
Failed to load commit list.
Merged

[DataStreamToSpanner] Improvement: Adding group by key step before Spanner write step #3249

Addressing comments
826933f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2026 in 1s

54.91% (+3.98%) compared to 63091f1

View this Pull Request on Codecov

54.91% (+3.98%) compared to 63091f1

Details

Codecov Report

❌ Patch coverage is 56.36364% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.91%. Comparing base (63091f1) to head (826933f).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...eleport/v2/templates/SpannerTransactionWriter.java 0.00% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3249      +/-   ##
============================================
+ Coverage     50.93%   54.91%   +3.98%     
+ Complexity     5157     2277    -2880     
============================================
  Files           977      493     -484     
  Lines         60347    28861   -31486     
  Branches       6594     3036    -3558     
============================================
- Hits          30735    15848   -14887     
+ Misses        27457    12050   -15407     
+ Partials       2155      963    -1192     
Components Coverage Δ
spanner-templates 71.94% <56.36%> (+0.89%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 80.04% <56.36%> (-0.08%) ⬇️
spanner-live-reverse-replication 77.58% <ø> (-0.19%) ⬇️
spanner-bulk-migration 88.08% <ø> (-0.38%) ⬇️
Files with missing lines Coverage Δ
...tes/CreateKeyValuePairsWithPrimaryKeyHashDoFn.java 100.00% <100.00%> (ø)
...ort/v2/templates/SpannerTransactionWriterDoFn.java 51.80% <100.00%> (ø)
.../v2/templates/datastream/ChangeEventConvertor.java 87.50% <ø> (+5.55%) ⬆️
...eleport/v2/templates/SpannerTransactionWriter.java 0.00% <0.00%> (ø)

... and 518 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.