Add Iceberg to SQL Server YAML template#3302
Add Iceberg to SQL Server YAML template#3302derrickaw merged 14 commits intoGoogleCloudPlatform:mainfrom
Conversation
Summary of ChangesHello @ihebimad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a new Dataflow Flex Template designed to streamline the process of moving batch data from Iceberg tables into SQL Server. The template leverages a YAML-based definition for easy configuration and includes robust integration tests to confirm its reliability. It provides flexible options for specifying Iceberg catalog properties, SQL Server connection details, and data transformation rules like filtering and field selection, enhancing its utility for various data migration scenarios. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3302 +/- ##
=============================================
- Coverage 51.25% 37.10% -14.15%
+ Complexity 5669 470 -5199
=============================================
Files 1001 194 -807
Lines 60954 11341 -49613
Branches 6682 1117 -5565
=============================================
- Hits 31240 4208 -27032
+ Misses 27531 6799 -20732
+ Partials 2183 334 -1849
🚀 New features to boost your workflow:
|
|
Looks like the test is failing before staging the template. Might not be the script issue |
yaml/src/main/java/com/google/cloud/teleport/templates/yaml/IcebergToSqlServerYaml.java
Outdated
Show resolved
Hide resolved
yaml/src/main/java/com/google/cloud/teleport/templates/yaml/IcebergToSqlServerYaml.java
Outdated
Show resolved
Hide resolved
|
Thank you @derrickaw for the heads-up (cause I've been trying as well to change the flex_container_name in .yaml file not only .java file) |
|
Hi @ihebimad, can you try rebasing since the prior issue is fixed now? Thanks. |
- Added iceberg-to-sqlserver.yaml blueprint and generated wrapper. - Implemented IcebergToSqlServerYamlIT integration test using Cloud SQL. - Generated/updated template documentation. - Integration tests pass successfully
…tion test failures
Fixing IT tests
empty commit trigger IT
yaml/src/main/java/com/google/cloud/teleport/templates/yaml/IcebergToSqlServerYaml.java
Outdated
Show resolved
Hide resolved
|
regen yaml/src/main/java/com/google/cloud/teleport/templates/yaml/IcebergToSqlServerYaml.java after yaml pipeline updated with different configs. thanks |
|
hi @derrickaw done, please let me know if anything further is needed |
Added iceberg-to-sqlserver.yaml blueprint and generated wrapper.
Implemented IcebergToSqlServerYamlIT integration test.
Generated/updated template documentation.
Integration tests pass successfully (using Cloud SQL): Dataflow Job ID: 2026-02-02_06_45_54-9397309740239157576