Skip to content

Add Iceberg to SQL Server YAML template#3302

Merged
derrickaw merged 14 commits intoGoogleCloudPlatform:mainfrom
ihebimad:main
Mar 18, 2026
Merged

Add Iceberg to SQL Server YAML template#3302
derrickaw merged 14 commits intoGoogleCloudPlatform:mainfrom
ihebimad:main

Conversation

@ihebimad
Copy link
Contributor

@ihebimad ihebimad commented Feb 6, 2026

Added iceberg-to-sqlserver.yaml blueprint and generated wrapper.
Implemented IcebergToSqlServerYamlIT integration test.
Generated/updated template documentation.
Integration tests pass successfully (using Cloud SQL): Dataflow Job ID: 2026-02-02_06_45_54-9397309740239157576

@gemini-code-assist
Copy link

Summary of Changes

Hello @ihebimad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a new Dataflow Flex Template designed to streamline the process of moving batch data from Iceberg tables into SQL Server. The template leverages a YAML-based definition for easy configuration and includes robust integration tests to confirm its reliability. It provides flexible options for specifying Iceberg catalog properties, SQL Server connection details, and data transformation rules like filtering and field selection, enhancing its utility for various data migration scenarios.

Highlights

  • New Dataflow Template: Introduced a new Dataflow Flex Template for transferring data from Iceberg tables to SQL Server databases, defined using YAML.
  • Integration Testing: Added a comprehensive integration test (IcebergToSqlServerYamlIT) to validate the functionality of the new template, ensuring data transfer correctness.
  • Documentation and Configuration: Generated detailed documentation for the template, including parameters, usage instructions, and Terraform integration. Also, extended Iceberg options to support data manipulation during reads.
Changelog
  • yaml/README_Iceberg_To_SqlServer_Yaml.md
    • Added new documentation for the Iceberg to SQL Server YAML template, detailing required and optional parameters.
    • Included instructions for building, staging, and running the template using gcloud and Maven.
    • Provided Terraform configuration examples for managing the template job.
  • yaml/src/main/java/com/google/cloud/teleport/templates/yaml/IcebergToSqlServerYaml.java
    • Created a new Java interface to define the metadata and parameters for the Iceberg_To_SqlServer_Yaml template.
    • Annotated template parameters with descriptions, help text, examples, and validation rules.
  • yaml/src/main/python/options/iceberg_options.yaml
    • Added new iceberg_read_options to allow for dropping, filtering, and keeping specific fields during Iceberg data reads.
  • yaml/src/main/yaml/IcebergToSqlServer.yaml
    • Defined the new Iceberg_To_SqlServer_Yaml pipeline using YAML, orchestrating ReadFromIceberg and WriteToSqlServer transforms.
    • Mapped template parameters to the configurations of the Iceberg read and SQL Server write operations.
  • yaml/src/test/java/com/google/cloud/teleport/templates/yaml/IcebergToSqlServerYamlIT.java
    • Implemented a new integration test for the IcebergToSqlServerYaml template.
    • The test sets up Iceberg and SQL Server resources, writes sample data to Iceberg, launches the Dataflow pipeline, and asserts the correct transfer of data to SQL Server.
Activity
  • The author ihebimad initiated the pull request to add the Iceberg to SQL Server YAML template.
  • A new YAML blueprint and its generated wrapper were included in the changes.
  • An integration test, IcebergToSqlServerYamlIT, was developed and successfully passed, as indicated by the Dataflow Job ID: 2026-02-02_06_45_54-9397309740239157576.
  • The template documentation was generated and updated as part of this effort.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@derrickaw derrickaw added the addition New feature or request label Feb 6, 2026
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.10%. Comparing base (77f4d11) to head (e2a7e64).
⚠️ Report is 110 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (77f4d11) and HEAD (e2a7e64). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (77f4d11) HEAD (e2a7e64)
11 1
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3302       +/-   ##
=============================================
- Coverage     51.25%   37.10%   -14.15%     
+ Complexity     5669      470     -5199     
=============================================
  Files          1001      194      -807     
  Lines         60954    11341    -49613     
  Branches       6682     1117     -5565     
=============================================
- Hits          31240     4208    -27032     
+ Misses        27531     6799    -20732     
+ Partials       2183      334     -1849     
Components Coverage Δ
spanner-templates ∅ <ø> (∅)
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration ∅ <ø> (∅)
spanner-live-reverse-replication ∅ <ø> (∅)
spanner-bulk-migration ∅ <ø> (∅)
gcs-spanner-dv ∅ <ø> (∅)
see 838 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tarun-google
Copy link
Contributor

Looks like the test is failing before staging the template. Might not be the script issue

@derrickaw
Copy link
Contributor

Hi @ihebimad - yesterday afternoon we realized that yaml/python workflow is failing. @Abacn and I are trying to figure out what is the issue. Will let you know when fixed. Thanks

@ihebimad
Copy link
Contributor Author

Thank you @derrickaw for the heads-up (cause I've been trying as well to change the flex_container_name in .yaml file not only .java file)
While waiting, for now I'll just push to be similaire as other templates (as per PR #3268)

@Abacn
Copy link
Contributor

Abacn commented Feb 20, 2026

Hi @ihebimad - yesterday afternoon we realized that yaml/python workflow is failing. @Abacn and I are trying to figure out what is the issue. Will let you know when fixed. Thanks

internal tracker: b/485853563

@derrickaw
Copy link
Contributor

derrickaw commented Feb 23, 2026

Hi @ihebimad, can you try rebasing since the prior issue is fixed now? Thanks.

- Added iceberg-to-sqlserver.yaml blueprint and generated wrapper.
- Implemented IcebergToSqlServerYamlIT integration test using Cloud SQL.
- Generated/updated template documentation.
- Integration tests pass successfully
Fixing IT tests
@ihebimad ihebimad reopened this Feb 24, 2026
ihebimad and others added 2 commits February 25, 2026 13:41
@derrickaw
Copy link
Contributor

regen yaml/src/main/java/com/google/cloud/teleport/templates/yaml/IcebergToSqlServerYaml.java after yaml pipeline updated with different configs. thanks

@ihebimad
Copy link
Contributor Author

ihebimad commented Mar 9, 2026

hi @derrickaw done, please let me know if anything further is needed

@derrickaw derrickaw merged commit 592537e into GoogleCloudPlatform:main Mar 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New feature or request size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants