Skip to content

update googleads template to v23#3344

Draft
derrickaw wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
derrickaw:20260217_fixGoogleAdsTemplatev19tov23
Draft

update googleads template to v23#3344
derrickaw wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
derrickaw:20260217_fixGoogleAdsTemplatev19tov23

Conversation

@derrickaw
Copy link
Contributor

@derrickaw derrickaw commented Feb 17, 2026

  1. Fixes [Bug]: Google Ads template is failing due to v19 sunset #3343
  2. But need to hold until Beam 2.72 is released :(

@gemini-code-assist
Copy link

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Google Ads API version used within the google-ads-to-googlecloud template from v19 to v23. This ensures the template remains compatible with the latest API features and addresses necessary adjustments due to API evolution, specifically a field name change for campaign start dates.

Highlights

  • Google Ads API Version Upgrade: The Google Ads API version used in the google-ads-to-googlecloud template has been upgraded from v19 to v23.
  • Dependency Updates: The google-ads.version in pom.xml was updated to 42.0.0, and an explicit version 2.72.0-SNAPSHOT was added for the beam-sdks-java-io-google-ads dependency.
  • API Field Name Change: Code and tests were adjusted to reflect a change in the Google Ads API where campaign.start_date is now campaign.start_date_time.
Changelog
  • v2/google-ads-to-googlecloud/pom.xml
    • Updated the google-ads.version property from 41.0.0 to 42.0.0.
    • Added an explicit version 2.72.0-SNAPSHOT for the beam-sdks-java-io-google-ads dependency.
  • v2/google-ads-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/templates/GoogleAdsToBigQuery.java
    • Updated the import statement for GoogleAdsRow from v19 to v23.
  • v2/google-ads-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/transforms/GoogleAdsRowToReportRowJsonFn.java
    • Updated the import statement for GoogleAdsRow from v19 to v23.
  • v2/google-ads-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/utils/GoogleAdsRateLimitPolicyFactory.java
    • Updated the import statement for GoogleAdsError from v19 to v23.
  • v2/google-ads-to-googlecloud/src/main/java/com/google/cloud/teleport/v2/utils/GoogleAdsUtils.java
    • Updated the import statement for GoogleAdsRow from v19 to v23.
  • v2/google-ads-to-googlecloud/src/test/java/com/google/cloud/teleport/v2/transforms/GoogleAdsRowToReportRowJsonFnTest.java
    • Updated import statements for CampaignStatusEnum, Campaign, and GoogleAdsRow from v19 to v23.
    • Modified the test query to use campaign.start_date_time instead of campaign.start_date.
    • Updated the Campaign builder to use setStartDateTime instead of setStartDate.
    • Adjusted the expected JSON output to reflect campaign_start_date_time.
Activity
  • No specific activity (comments, reviews, progress) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@derrickaw derrickaw added improvement Making existing code better bug-fix labels Feb 17, 2026
@irfanrafiq-justeat
Copy link

Thanks @derrickaw for the quick turnaround on both the template and the Beam dependency updates, really appreciated.

I’ve noticed that this template tends to get updated quite late often close to, or even just after, the sunset date. Is there anything that can be put in place to ensure these updates happen a bit earlier going forward?

Thanks

@derrickaw
Copy link
Contributor Author

Hi @irfanrafiq-justeat

  1. I created this issue to track the next upgrade so that we jump to minimum of v26 before v23 deprecates in Feb 2027 - [Action Item]: In November 2026 - Upgrade Google Ads to a higher version tasks #3346
  2. I will also investigate either setting up a new workflow that creates a pending task to upgrade the API version on a reliable cadence or some other method to minimize the chance of this happening again.

Thanks

@irfanrafiq-justeat
Copy link

irfanrafiq-justeat commented Feb 17, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix improvement Making existing code better size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Google Ads template is failing due to v19 sunset

2 participants