Skip to content

Comments

make attempt and operation timeout configurable on export job#3376

Merged
damccorm merged 1 commit intoGoogleCloudPlatform:mainfrom
mutianf:timeouts
Feb 19, 2026
Merged

make attempt and operation timeout configurable on export job#3376
damccorm merged 1 commit intoGoogleCloudPlatform:mainfrom
mutianf:timeouts

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented Feb 19, 2026

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @mutianf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Bigtable export job by introducing configurable timeouts for Bigtable read RPC operations and their individual attempts. This provides greater control and flexibility for users to fine-tune the job's behavior when interacting with Bigtable, potentially improving stability and performance in various network conditions or with large datasets.

Highlights

  • Bigtable Read Timeouts: Introduced new template parameters (bigtableReadRpcTimeoutMs and bigtableReadRpcAttemptTimeoutMs) to allow users to configure Bigtable read RPC and attempt timeouts for export jobs.
  • Dependency Update: Updated the bigtable-beam-import.version dependency from 2.15.6 to 2.16.0.
Changelog
  • v1/pom.xml
    • Updated bigtable-beam-import.version from 2.15.6 to 2.16.0.
  • v1/src/main/java/com/google/cloud/teleport/templates/ExportJobPlaceholder.java
    • Added bigtableReadRpcTimeoutMs template parameter for Bigtable read RPC timeout.
    • Added bigtableReadRpcAttemptTimeoutMs template parameter for Bigtable read RPC attempt timeout.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.06%. Comparing base (f98298a) to head (4c21465).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3376      +/-   ##
============================================
+ Coverage     51.04%   51.06%   +0.02%     
- Complexity     5209     5212       +3     
============================================
  Files           992      994       +2     
  Lines         60643    60723      +80     
  Branches       6650     6657       +7     
============================================
+ Hits          30954    31007      +53     
- Misses        27510    27536      +26     
- Partials       2179     2180       +1     
Components Coverage Δ
spanner-templates 70.88% <ø> (+0.09%) ⬆️
spanner-import-export 69.05% <ø> (+0.12%) ⬆️
spanner-live-forward-migration 79.82% <ø> (+<0.01%) ⬆️
spanner-live-reverse-replication 77.36% <ø> (-0.05%) ⬇️
spanner-bulk-migration 87.98% <ø> (+0.06%) ⬆️
Files with missing lines Coverage Δ
...cloud/teleport/templates/ExportJobPlaceholder.java 0.00% <ø> (ø)

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damccorm damccorm added the addition New feature or request label Feb 19, 2026
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 18e98da into GoogleCloudPlatform:main Feb 19, 2026
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New feature or request size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants