Add AWS support for spot instances#6149
Open
haykking wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
Open
Add AWS support for spot instances#6149haykking wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
haykking wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
Conversation
hubatish
requested changes
Oct 16, 2025
haykking
force-pushed
the
feature/add-aws-spot-instances-support
branch
from
16da473 to
ba6abdd
Compare
hubatish
reviewed
Oct 20, 2025
Collaborator
hubatish
left a comment
hubatish
left a comment
There was a problem hiding this comment.
What gpu / commands did you try with?
| super().__init__(spec) | ||
| self._ChooseSecondZone() | ||
| is_rare_gpu = virtual_machine.GPU_TYPE.value in _RARE_GPU_TYPES | ||
| is_rare_gpu = virtual_machine.GPU_TYPE.value in _RARE_GPU_TYPES |
Collaborator
There was a problem hiding this comment.
Is this line duplicate with the line above it?
| self.cluster_version: str = self.cluster_version or _DEAULT_K8S_VERSION | ||
| # Add spot instance support similar to EksAutoCluster | ||
| is_rare_gpu = virtual_machine.GPU_TYPE.value in _RARE_GPU_TYPES | ||
| self.use_spot: bool = aws_flags.USE_AWS_SPOT_INSTANCES.value or is_rare_gpu |
Collaborator
There was a problem hiding this comment.
It's used by 2 implementations; may as well move this variable to BaseEksCluster's init.
| if machine_family: | ||
| return [f'karpenter.k8s.aws/instance-family: {machine_family}'] | ||
| return [] | ||
| selectors.append(f'karpenter.k8s.aws/instance-family: {machine_family}') |
Collaborator
There was a problem hiding this comment.
Does specifying instance family work with also specifying gpus? I think our default arguments would specify both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.