test: add Windows compatibility CI #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
- Replace Jinja2 conditionals in filenames with Python-based logic - Add CONDITIONAL_FILES mapping and apply_conditional_files function - Rename all conditional files to simple names - Files are now filtered post-copy based on config values This fixes the Windows path length issue where Jinja2 syntax in filenames exceeded the 260 character MAX_PATH limit.
Add **/.venv/* pattern to _copy_without_render to prevent Cookiecutter from parsing .venv files at any directory depth.
Set PYTHONIOENCODING and PYTHONUTF8 env vars to handle emoji output.
- Fix import sorting - Use list unpacking instead of concatenation (RUF005)
- Add HttpRetryOptions with 3 attempts to all ADK agents (adk_base, adk_live, adk_a2a_base, agentic_rag) - Improve pipeline parity test retry logic with exponential backoff for 429 errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Windows struggled to use the Agent Starter Pack because:
{% if ... %}) exceed Windows' 260 character MAX_PATH limit%character in filenames is interpreted as environment variable syntax on WindowsSolution
CONDITIONAL_FILESdict mapping file paths to Python condition functionsapply_conditional_files()function to handle file inclusion/exclusion post-copyunused_*logicAdditional Fixes
**/.venv/*to_copy_without_renderto exclude nested.venvdirectories from Jinja2 parsing