feat: restrict session type selection to adk_base and agentic_rag #665
Conversation
Limit session type selection for cloud_run deployment to only adk_base and agentic_rag agents. Other agents now default to in_memory sessions with a warning if the user explicitly specifies a different session type.
Summary of ChangesHello @eliasecchig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the session type selection mechanism for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively restricts session type selection for cloud_run deployments to specific agents, defaulting to in-memory sessions for others and providing a helpful warning. The implementation is clear and correct. My review includes suggestions to improve maintainability by refactoring a hardcoded list into a module-level constant and to enhance robustness by adding unit tests for the new logic.
| requires_session = config.get("settings", {}).get("requires_session", False) | ||
|
|
||
| # Session type selection is only available for these agents on cloud_run | ||
| session_type_supported_agents = ("adk_base", "agentic_rag") |
There was a problem hiding this comment.
For better maintainability and to follow common Python conventions for constants, consider defining this as a module-level constant (e.g., SESSION_TYPE_SUPPORTED_AGENTS) at the top of the file. This makes it easier to find and modify the list of supported agents in the future.
1 participant
Summary
adk_baseandagentic_ragagentsin_memorysessions when using cloud_runChanges
session_type_supported_agentstuple to define which agents support session type selectionTest plan
adk_basewith--session-type cloud_sql→ works correctlyagentic_ragwith--session-type cloud_sql→ works correctlyadk_livewith--session-type cloud_sql→ shows warning, uses in_memorylanggraph_basewith--session-type cloud_sql→ shows warning, uses in_memory