Skip to content

Conversation

@eliasecchig
Copy link
Collaborator

Summary

  • Forward interactively-entered project name to nested uvx command
  • Add project_name parameter to check_and_execute_with_version_lock and fetch_remote_template

Problem

When using the interactive CLI and selecting an ADK sample with version lock, the project name entered interactively was not being forwarded to the nested uvx command. The nested command would then prompt for the project name again.

This happened because sys.argv only contains CLI arguments, not interactively entered values. The nested command was built from sys.argv[1:], missing the interactive project name.

Solution

Pass project_name through fetch_remote_template and check_and_execute_with_version_lock. When building the nested uvx command, check if project_name is in sys.argv - if not, it was entered interactively and needs to be added to the command args.

When using the interactive CLI and selecting an ADK sample with version
lock, the project name entered interactively was not being forwarded to
the nested uvx command. This fix passes the project_name through
fetch_remote_template and check_and_execute_with_version_lock, and adds
it to the command args if it was entered interactively (not in sys.argv).
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @eliasecchig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a user experience friction point in the interactive CLI. Previously, when creating a project using an ADK sample with version locking, the project name entered by the user was not consistently propagated to subsequent nested commands. This resulted in the user being prompted for the same project name multiple times. The changes introduce a mechanism to correctly pass the interactively provided project name through the relevant functions, ensuring it is included in the arguments for any nested command executions and streamlining the project creation workflow.

Highlights

  • Interactive Project Name Forwarding: The pull request resolves an issue where project names entered interactively were not being forwarded to nested uvx commands, leading to redundant prompts.
  • Parameter Addition: The project_name parameter has been added to the check_and_execute_with_version_lock and fetch_remote_template functions to facilitate the passing of the project name.
  • Argument Construction Logic: New logic ensures that if a project_name was provided interactively (i.e., not present in sys.argv), it is correctly inserted into the command arguments for the nested uvx call.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly forwards the interactively-entered project name to the nested uvx command, fixing an issue where the user was prompted twice. The changes involve passing the project_name through fetch_remote_template and check_and_execute_with_version_lock. I've found one potential issue in an edge case within the argument construction logic for the nested command, for which I've provided a suggestion.

@eliasecchig eliasecchig merged commit c82c49a into main Dec 22, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant