feat: migrate from mypy to ty for type checking #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace mypy with ty (Astral's Rust-based type checker) for significantly faster type checking in both the ASP CLI and generated templates. - Replace mypy with ty in lint dependencies - Migrate [tool.mypy] config to [tool.ty] in pyproject.toml files - Update Makefiles to use `ty check` instead of `mypy` - Update CI/CD lint configuration (.cloudbuild/ci/lint.yaml) - Remove SKIP_MYPY workaround from test_template_linting.py - Remove obsolete `# mypy:` comments from source files - Add .ty/ to .gitignore files - Regenerate makefile snapshots and lock files - Update documentation (CONTRIBUTING.md, GEMINI.md, README.md) Benefits: - 10-100x faster than mypy (Rust-based) - Unified tooling with ruff/uv (same Astral team) - Simplified dependencies (removed types-* stub packages)
Contributor
|
Note The number of changes in this pull request is too large for Gemini Code Assist to generate a summary. |
Add missing ty rule configurations to ignore errors that mypy was configured to suppress: - unresolved-attribute: for dynamic attribute access on A2A types - invalid-assignment: for dynamic dict subscript assignments - invalid-return-type: for generator functions with None annotations Remove possibly-missing-attribute (not a valid ty rule name).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Configuration
[project.optional-dependencies].lint[tool.mypy]→[tool.ty]config in pyproject.toml files.ty/cache directory to .gitignore filesBuild & CI
make lintto usety checkinstead ofmypy.cloudbuild/ci/lint.yamlfor CI lint stepTests
SKIP_MYPYworkaround fromtest_template_linting.pyCleanup
# mypy:file-level directives (14 files)types-pyyamlandtypes-requestsstub dependencies from generated projectsDocumentation
Benefits
Test Plan
make lintpassesadk_base + cloud_runadk_base + agent_engineadk_live + cloud_runlanggraph_base + agent_engine