feat: migrate cicd to gcloud storage from gsutil

[kweinmeister]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @kweinmeister, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the CI/CD infrastructure by migrating all Google Cloud Storage operations from the legacy gsutil command-line tool to the recommended gcloud storage interface. This change ensures that the Terraform backend setup and state management processes align with current Google Cloud best practices, improving maintainability and compatibility with the broader gcloud ecosystem.

Highlights

• Migration to gcloud storage: The CI/CD setup scripts have been updated to use gcloud storage commands instead of gsutil for interacting with Google Cloud Storage buckets.
• Bucket Operations Refactored: Commands for checking bucket existence, creating new buckets, and enabling versioning have been replaced with their gcloud storage equivalents.
• Test Suite Updates: The test suite has been adjusted to mock gcloud storage commands, ensuring continued test coverage for the updated functionality.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully migrates from gsutil to gcloud storage commands for managing Google Cloud Storage buckets, which is a good practice. However, I've identified a critical issue in both updated files where an incorrect flag is used to enable bucket versioning. This would cause the setup to fail. I've provided suggestions to fix this and to improve efficiency by combining two separate commands into a single, atomic operation.

[eliasecchig]

LGTM! The migration from gsutil to gcloud storage looks correct.

Regarding the review comments about the --versioning flag: the PR is correct as-is. The gcloud storage buckets update command uses --versioning (not --versioning-enabled), as confirmed by gcloud storage buckets update --help:

--[no-]versioning
    Allows you to configure a Cloud Storage bucket to keep old versions of
    objects. Use --versioning to enable and --no-versioning to disable.

Also, the suggestion to combine bucket creation with versioning enablement isn't possible - gcloud storage buckets create doesn't have a --versioning flag, so the two-step approach (create then update) is the correct implementation.

[eliasecchig]

/gcbrun