fix: pin google-cloud-aiplatform to version 1.130.0#738
Conversation
Pin the dependency to avoid issues with newer versions. Regenerated all lock files.
Summary of ChangesHello @eliasecchig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the stability of the project by addressing potential breaking changes or issues that might arise from newer versions of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request pins the google-cloud-aiplatform dependency to version 1.130.0 to avoid breaking changes from newer versions. While this ensures stability, it also prevents receiving bug fixes and security patches. I've suggested using a pessimistic version constraint (~=1.130.0) instead of a hard pin (==1.130.0). This would allow for patch-level updates, providing a better balance between stability and long-term maintainability.
- Remove deprecated EventLoggerProvider and set_event_logger_provider - Add ty ignore rules for third-party library type issues
…orm#738) * fix: pin google-cloud-aiplatform to version 1.130.0 Pin the dependency to avoid issues with newer versions. Regenerated all lock files. * fix: remove deprecated OpenTelemetry APIs and add ty ignore rules - Remove deprecated EventLoggerProvider and set_event_logger_provider - Add ty ignore rules for third-party library type issues
Summary
google-cloud-aiplatformdependency to version1.130.0Problem
Newer versions of
google-cloud-aiplatformare not currently able to export struct logs, required for telemetry.Solution
Pinned the dependency to a known working version (1.130.0) in the base template
pyproject.tomlfor both Cloud Run and Agent Engine deployments.