fix: use **/* glob pattern for agentic_rag and adk_live E2E triggers

[eliasecchig]

Summary

• Fix included_files glob patterns for agentic_rag and adk_live E2E build triggers
• Change ** to **/* so file changes within these directories actually trigger builds

Problem

E2E builds for agentic_rag and adk_live were not being triggered when files in their agent directories changed. The ** glob pattern may not match files in Cloud Build included_files.

Changes

• .cloudbuild/terraform/build_triggers.tf: Update glob patterns from ** to **/* for agentic_rag and adk_live entries in e2e_agent_deployment_included_files
• Terraform already applied

[gemini-code-assist]

Summary of Changes

Hello @eliasecchig, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where End-to-End (E2E) builds for the agentic_rag and adk_live agents were failing to trigger due to misconfigured glob patterns in the Cloud Build setup. By refining these patterns, the change ensures that any modifications within the respective agent directories will now correctly initiate their associated E2E build processes, thereby improving the reliability of the CI/CD pipeline for these components.

Highlights

• Glob Pattern Fix: Corrected the included_files glob patterns for agentic_rag and adk_live E2E build triggers.
• Build Trigger Reliability: Updated ** to **/* in the glob patterns to ensure that file changes within the specified directories properly trigger builds, resolving an issue where builds were not being initiated.

Changelog

• .cloudbuild/terraform/build_triggers.tf
  • Updated glob patterns for agentic_rag and adk_live E2E build triggers from ** to **/*.

Activity

• No human activity detected on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes the glob patterns for E2E build triggers by changing ** to **/*, ensuring that file changes within the agentic_rag and adk_live directories trigger the builds as intended. I've added one suggestion to remove a redundant glob pattern to improve the configuration's clarity. Overall, the change is a good fix.

[gemini-code-assist]

This glob pattern is redundant because the pattern agent_starter_pack/agents/agentic_rag/**/* on the preceding line already includes all files and subdirectories under agent_starter_pack/agents/agentic_rag/, which covers the data_ingestion path. This line can be safely removed to simplify the configuration.