fix: use europe-west4 region for agentic_rag E2E tests#799
Conversation
The Vector Search Collections beta API is not available in europe-west1, causing E2E tests to fail with a 501/404 error. Route agentic_rag tests to europe-west4 where the API is supported.
Summary of ChangesHello @eliasecchig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses persistent failures in Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly changes the region for agentic_rag E2E tests to europe-west4 to resolve an API availability issue. The implementation is correct. I've added one suggestion to refactor the region selection logic using a dictionary, which will improve maintainability and make it easier to add other agent-specific regions in the future.
Summary
Problem
E2E builds for agentic_rag with vertex_ai_vector_search fail because the Vector Search Collections beta API (
vectorsearch_v1beta) returns a 501/404 error in europe-west1, indicating the endpoint is not available in that region.Changes
tests/cicd/test_e2e_deployment.py: Addagentic_ragto region routing logic so it useseurope-west4where the API is supported