fix: add RAG projects to scheduled cleanup

[eliasecchig]

Summary

• Add asp-rag-dev, asp-rag-stg, asp-rag-prd to the scheduled cleanup project list
• Unify _PROJECT_IDS and _E2E_PROJECT_IDS into a single substitution variable

Problem

RAG project test resources (Agent Engines, Vector Search, Service Accounts, etc.) were not being cleaned up by the daily scheduled job because the RAG projects were missing from the cleanup config.

Changes

• .cloudbuild/scheduled-cleanup.yaml: Add RAG projects to _PROJECT_IDS, remove redundant _E2E_PROJECT_IDS substitution (both env vars now fed from _PROJECT_IDS)

[gemini-code-assist]

Summary of Changes

Hello @eliasecchig, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where test resources for RAG projects were not being properly cleaned up by the daily scheduled job. By extending the cleanup configuration to include these projects and unifying related project ID variables, it ensures that all relevant test resources are regularly maintained, preventing resource accumulation and potential cost overruns.

Highlights

• RAG Project Cleanup: Added asp-rag-dev, asp-rag-stg, and asp-rag-prd to the list of projects included in the scheduled cleanup process.
• Variable Unification: Consolidated _PROJECT_IDS and _E2E_PROJECT_IDS into a single substitution variable (_PROJECT_IDS) to streamline configuration.

Changelog

• .cloudbuild/scheduled-cleanup.yaml
  • Added asp-rag-dev, asp-rag-stg, and asp-rag-prd to the _PROJECT_IDS substitution variable.
  • Modified the E2E_PROJECT_IDS environment variable to reference _PROJECT_IDS instead of the now-removed _E2E_PROJECT_IDS substitution variable.
  • Removed the redundant _E2E_PROJECT_IDS substitution variable.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds the RAG projects (asp-rag-dev, asp-rag-stg, asp-rag-prd) to the scheduled cleanup configuration, addressing the issue of leftover test resources. The unification of _PROJECT_IDS and _E2E_PROJECT_IDS is a good refactoring that improves maintainability by removing redundancy. I've added one comment regarding a potential inconsistency in a related script that should be addressed to ensure manual cleanups behave as expected.

[gemini-code-assist]

While this change correctly adds the RAG projects for the scheduled cleanup job, the default values for PROJECT_IDS and E2E_PROJECT_IDS in tests/cicd/scripts/force-cleanup.sh are now out of sync. This could lead to incomplete cleanups if the script is run manually without the environment variables set.

To ensure consistency, please consider updating the default project lists on lines 18 and 19 of tests/cicd/scripts/force-cleanup.sh to include the new RAG projects.