fix: default prototype mode to deployment_target='none'#855
fix: default prototype mode to deployment_target='none'#855eliasecchig merged 3 commits intomainfrom
Conversation
When --prototype is used without an explicit --deployment-target, default to 'none' instead of picking the first available target. This avoids pulling in unnecessary deployment-specific files for minimal projects.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the behavior of the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly implements the desired behavior of defaulting to deployment_target='none' when using prototype mode without an explicit deployment target. The change is well-isolated and follows the project's conventions. I've added one suggestion to refactor a related code block to improve maintainability by reducing a small amount of code duplication.
Add missing /agent-engines/ segment to the console URL so playground and console links route correctly.
Summary
--prototypeis used without--deployment-target, default tononeinstead of picking the first available targetChanges
create.pyto check for prototype mode before falling through to normal target selection--prototypeand no explicit-d, setsdeployment_target='none'and prints an info message-dflag still takes precedence even in prototype mode