-
Notifications
You must be signed in to change notification settings - Fork 31
Add base container image Jax TCPX #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samos123
wants to merge
9
commits into
GoogleCloudPlatform:main
Choose a base branch
from
samos123:jax-tcpx-base-image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+78
−0
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4fa8006
Add base container image Jax TCPX
samos123 311d263
change to ARG
samos123 f2da51d
add cloudbuild example
samos123 8c6272d
update README
samos123 d91ada6
switch to ubuntu as base image
samos123 436275d
Revert "switch to ubuntu as base image"
samos123 762cd85
switch to ubuntu as base image
samos123 c6bba73
change version
samos123 3bf0aee
use absolute path in case child image uses workdir
samos123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| FROM python:3.10-slim | ||
|
|
||
| ENV VERSION=0.4.25 | ||
|
|
||
| RUN pip install --no-cache-dir --upgrade pip | ||
|
|
||
| RUN pip install --no-cache-dir --upgrade "jax[cuda12_pip]==${VERSION}" -f https://storage.googleapis.com/jax-releases/jax_cuda_releases.html | ||
|
|
||
| WORKDIR /workspace/ | ||
|
|
||
| ADD entrypoint.sh . | ||
|
|
||
| ENTRYPOINT ["bash", "entrypoint.sh"] | ||
|
|
||
| # Environment variables required by TCPX | ||
| ENV NCCL_NVLS_ENABLE=0 | ||
| ENV NCCL_CROSS_NIC=0 | ||
| ENV NCCL_ALGO=Ring | ||
| ENV NCCL_PROTO=Simple | ||
| ENV NCCL_DEBUG=INFO | ||
| ENV NCCL_NET_GDR_LEVEL=PIX | ||
| ENV NCCL_P2P_PXN_LEVEL=0 | ||
| ENV NCCL_DEBUG_SUBSYS=INIT,GRAPH,ENV,TUNING,NET,VERSION | ||
| ENV LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:/usr/local/tcpx/lib64" | ||
| ENV NCCL_GPUDIRECTTCPX_FORCE_ACK=0 | ||
| ENV NCCL_GPUDIRECTTCPX_TX_COMPLETION_NANOSLEEP=1000 | ||
| ENV NCCL_DYNAMIC_CHUNK_SIZE=524288 | ||
| ENV NCCL_P2P_NET_CHUNKSIZE=524288 | ||
| ENV NCCL_P2P_PCI_CHUNKSIZE=524288 | ||
| ENV NCCL_P2P_NVL_CHUNKSIZE=1048576 | ||
| ENV NCCL_NSOCKS_PERTHREAD=4 | ||
| ENV NCCL_SOCKET_NTHREADS=1 | ||
| ENV NCCL_MAX_NCHANNELS=12 | ||
| ENV NCCL_MIN_NCHANNELS=12 | ||
| ENV NCCL_GPUDIRECTTCPX_PROGRAM_FLOW_STEERING_WAIT_MICROS=1000000 | ||
| ENV NCCL_SOCKET_IFNAME=eth0 | ||
| ENV NCCL_GPUDIRECTTCPX_TX_BINDINGS="eth1:8-21,112-125;eth2:8-21,112-125;eth3:60-73,164-177;eth4:60-73,164-177" | ||
| ENV NCCL_GPUDIRECTTCPX_RX_BINDINGS="eth1:22-35,124-139;eth2:22-35,124-139;eth3:74-87,178-191;eth4:74-87,178-191" | ||
| ENV NCCL_GPUDIRECTTCPX_SOCKET_IFNAME=eth1,eth2,eth3,eth4 | ||
| ENV NCCL_GPUDIRECTTCPX_CTRL_DEV=eth0 | ||
| # Might require adjusting based on where the TCPX socket is mounted | ||
| ENV NCCL_GPUDIRECTTCPX_UNIX_CLIENT_PREFIX=/run/tcpx | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Base image with JAX and TCPX config | ||
|
|
||
| A base image to use with Jax |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| function on_script_completion { | ||
| # semaphore to cleanly exit hardware utilization monitor | ||
| touch /run/tcpx/workload_terminated | ||
| } | ||
| trap on_script_completion EXIT | ||
|
|
||
| exec "$@" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parambole not sure if this pip upgrade is really needed?