chore: Migrate Notebooks to Generative AI Repository #176
Conversation
holtskinner
requested review from
RajeshThallam and
Abhishekbhagwat
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request focuses on migrating several notebooks from the genai-on-vertex-ai repository to the generative-ai repository. The notebooks demonstrate multimodal prompting techniques using Gemini, specifically for audio, video, and PDF processing. The goal is to consolidate these resources into a more centralized location.
Highlights
- Notebook Migration: The core change involves moving the multimodal prompting notebooks for audio and video, as well as the PDF processing notebooks, to the
generative-airepository. This aims to consolidate related resources. - README Updates: The README files in the original locations are updated to indicate that the notebooks have been moved and to provide a link to the new location in the
generative-airepository. - Spatial Reasoning: The spatial reasoning notebook has been moved to the generative-ai repository, with the README updated to reflect the new location.
Changelog
Click here to see the changelog
- genai-on-vertex-ai/gemini/prompting_recipes/multimodal/README.md
- The README file is updated to indicate that the multimodal prompting notebooks have been moved to the
generative-airepository. - A link to the new location of the multimodal use cases notebook is provided.
- The README file is updated to indicate that the multimodal prompting notebooks have been moved to the
- genai-on-vertex-ai/gemini/prompting_recipes/multimodal/multimodal_prompting_audio.ipynb
- The notebook file has been removed as it is now located in the
generative-airepository.
- The notebook file has been removed as it is now located in the
- genai-on-vertex-ai/gemini/prompting_recipes/multimodal/multimodal_prompting_video.ipynb
- The notebook file has been removed as it is now located in the
generative-airepository.
- The notebook file has been removed as it is now located in the
- genai-on-vertex-ai/gemini/prompting_recipes/pdf_processing/1_extract_pdf_pages_with_gemini.ipynb
- The notebook file has been removed as it is now located in the
generative-airepository.
- The notebook file has been removed as it is now located in the
- genai-on-vertex-ai/gemini/prompting_recipes/pdf_processing/2_pdf_info_extraction_with_gemini.ipynb
- The notebook file has been removed as it is now located in the
generative-airepository.
- The notebook file has been removed as it is now located in the
- genai-on-vertex-ai/gemini/prompting_recipes/pdf_processing/README.md
- The README file is updated to indicate that the PDF processing notebooks have been moved to the
generative-airepository. - A link to the new location of the document processing notebook is provided.
- The README file is updated to indicate that the PDF processing notebooks have been moved to the
- genai-on-vertex-ai/gemini/prompting_recipes/spatial_reasoning/README.md
- The README file is updated to indicate that the spatial reasoning notebook has been moved to the
generative-airepository. - A link to the new location of the spatial understanding notebook is provided.
- The README file is updated to indicate that the spatial reasoning notebook has been moved to the
- genai-on-vertex-ai/gemini/prompting_recipes/spatial_reasoning/spatial_reasoning_SDK_for_gemini2.ipynb
- The notebook file has been removed as it is now located in the
generative-airepository.
- The notebook file has been removed as it is now located in the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A digital migration,
Code finds a new location,
Gemini's flight,
Into the AI light,
A unified creation.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request focuses on migrating notebooks to a new repository, which is a good step towards organizing the project. The changes primarily involve updating file paths and references. It's crucial to ensure that all links and references are updated correctly to avoid broken links and maintain functionality.
Summary of Findings
- File Migration: The pull request migrates several notebook files and a README to a new repository location. Ensure that all links and references to these files are updated across the project to maintain functionality.
- README Updates: The README files are being updated to point to the new locations of the migrated notebooks. Verify that these updates are accurate and that the new locations are accessible.
Merge Readiness
The pull request appears to be straightforward, involving file migrations and updates to README files. However, it's important to verify that all links and references to the migrated files are updated correctly across the project. Given the nature of the changes, I am unable to directly approve the pull request, and users should have others review and approve this code before merging. If the updates are accurate and the new locations are accessible, the pull request is ready to be merged.
Follow-up to GoogleCloudPlatform/generative-ai#1987