Skip to content

Bump node-forge and google-p12-pem in /octokit#707

Open
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/npm_and_yarn/octokit/multi-96acc0698d
Open

Bump node-forge and google-p12-pem in /octokit#707
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/npm_and_yarn/octokit/multi-96acc0698d

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Mar 27, 2026

Bumps node-forge and google-p12-pem. These dependencies needed to be updated together.
Updates node-forge from 0.10.0 to 1.4.0

Changelog

Sourced from node-forge's changelog.

1.4.0 - 2026-03-24

Security

  • HIGH: Denial of Service in BigInteger.modInverse()
    • A Denial of Service (DoS) vulnerability exists due to an infinite loop in the BigInteger.modInverse() function (inherited from the bundled jsbn library). When modInverse() is called with a zero value as input, the internal Extended Euclidean Algorithm enters an unreachable exit condition, causing the process to hang indefinitely and consume 100% CPU.
    • Reported by Kr0emer.
    • CVE ID: CVE-2026-33891
    • GHSA ID: GHSA-5gfm-wpxj-wjgq
  • HIGH: Signature forgery in RSA-PKCS due to ASN.1 extra field.
    • RSASSA PKCS#1 v1.5 signature verification accepts forged signatures for low public exponent keys (e=3). Attackers can forge signatures by stuffing "garbage" bytes within the ASN.1 structure in order to construct a signature that passes verification, enabling Bleichenbacher style forgery. This issue is similar to CVE-2022-24771, but adds bytes in an addition field within the ASN.1 structure, rather than outside of it.
    • Additionally, forge does not validate that signatures include a minimum of 8 bytes of padding as defined by the specification, providing attackers additional space to construct Bleichenbacher forgeries.
    • Reported as part of a U.C. Berkeley security research project by:
      • Austin Chu, Sohee Kim, and Corban Villa.
    • CVE ID: CVE-2026-33894
    • GHSA ID: GHSA-ppp5-5v6c-4jwp
  • HIGH: Signature forgery in Ed25519 due to missing S < L check.
    • Ed25519 signature verification accepts forged non-canonical signatures where the scalar S is not reduced modulo the group order (S >= L). A valid signature and its S + L variant both verify in forge, while Node.js crypto.verify (OpenSSL-backed) rejects the S + L variant, as defined by the specification. This class of signature malleability has been exploited in practice to bypass authentication and authorization logic (see CVE-2026-25793, CVE-2022-35961). Applications relying on signature uniqueness (i.e., dedup by signature bytes, replay tracking, signed-object canonicalization checks) may be bypassed.
    • Reported as part of a U.C. Berkeley security research project by:
      • Austin Chu, Sohee Kim, and Corban Villa.
    • CVE ID: CVE-2026-33895
    • GHSA ID: GHSA-q67f-28xg-22rw
  • HIGH: basicConstraints bypass in certificate chain verification.
    • pki.verifyCertificateChain() does not enforce RFC 5280 basicConstraints requirements when an intermediate certificate lacks both the basicConstraints and keyUsage extensions. This allows any leaf certificate (without these extensions) to act as a CA and sign other certificates, which node-forge will accept as valid.
    • Reported by Doruk Tan Ozturk (@​peaktwilight) - doruk.ch
    • CVE ID: CVE-2026-33896
    • GHSA ID: GHSA-2328-f5f3-gj25

... (truncated)

Commits

Updates google-p12-pem from 3.0.3 to 3.1.4

Release notes

Sourced from google-p12-pem's releases.

v3.1.4

3.1.4 (2022-04-11)

Bug Fixes

v3.1.3

3.1.3 (2022-01-10)

Bug Fixes

  • deps: update dependency node-forge to v1 (#382) (078735b)

google-p12-pem v3.1.2

Bug Fixes

google-p12-pem v3.1.1

Bug Fixes

v3.1.0

Features

  • add gcf-owl-bot[bot] to ignoreAuthors (#318) (e93e51b)
Changelog

Sourced from google-p12-pem's changelog.

3.1.4 (2022-04-11)

Bug Fixes

3.1.3 (2022-01-10)

Bug Fixes

  • deps: update dependency node-forge to v1 (#382) (078735b)

3.1.2 (2021-08-11)

Bug Fixes

3.1.1 (2021-07-21)

Bug Fixes

3.1.0 (2021-06-10)

Features

  • add gcf-owl-bot[bot] to ignoreAuthors (#318) (e93e51b)
Commits
  • aff0086 chore(main): release 3.1.4 (#404)
  • f375cca fix(deps): force fixed version of node-forge (#403)
  • e602210 chore(deps): update actions/checkout action to v3 (#1392) (#401)
  • f7df70d chore(deps): update actions/setup-node action to v3 (#1393) (#400)
  • 4095df8 chore: Enable Size-Label bot in all googleapis NodeJs repositories (#1382) (#...
  • 850355c chore(deps): update actions/checkout action to v3 (#395)
  • 40b7cd7 chore(deps): update actions/setup-node action to v3 (#394)
  • 65b5c88 docs(nodejs): version support policy edits (#1346) (#393)
  • ce2ed68 chore(deps): update actions/setup-node action to v2 (#391)
  • 7ddc2d0 build(node): switch back to keystore for publication (#1328) (#390)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot
Bump node-forge and google-p12-pem in /octokit
7aeb3c8 
Bumps [node-forge](https://github.com/digitalbazaar/forge) and [google-p12-pem](https://github.com/googleapis/google-p12-pem). These dependencies needed to be updated together.

Updates `node-forge` from 0.10.0 to 1.4.0
- [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md)
- [Commits](digitalbazaar/forge@0.10.0...v1.4.0)

Updates `google-p12-pem` from 3.0.3 to 3.1.4
- [Release notes](https://github.com/googleapis/google-p12-pem/releases)
- [Changelog](https://github.com/googleapis/google-p12-pem/blob/main/CHANGELOG.md)
- [Commits](googleapis/google-p12-pem@v3.0.3...v3.1.4)

---
updated-dependencies:
- dependency-name: node-forge
  dependency-version: 1.4.0
  dependency-type: indirect
- dependency-name: google-p12-pem
  dependency-version: 3.1.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 27, 2026
@dependabot dependabot bot mentioned this pull request Mar 27, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants