Adding AWS Glue connector code #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for job in page['Jobs']: | ||
| job_name = job['Name'] | ||
| # Optimization: Limit to latest run to reduce API calls | ||
| job_runs = self.__glue_client.get_job_runs(JobName=job_name, MaxResults=1) |
Collaborator
There was a problem hiding this comment.
Is it guaranteed to return the latest run?
| job_runs = self.__glue_client.get_job_runs(JobName=job_name, MaxResults=1) | ||
|
|
||
| for job_run in job_runs.get('JobRuns', []): | ||
| if job_run.get('JobRunState') == 'SUCCEEDED': |
Collaborator
There was a problem hiding this comment.
Is it possible to filter the jobs fetched in get_job_runs to only return jobs which 'SUCCEEDED'?
Comment on lines
+83
to
+85
| graph = self.__glue_client.get_dataflow_graph(PythonScript=script_location) | ||
| if graph: | ||
| sources = [edge['Source'] for edge in graph.get('Edges', [])] |
Collaborator
There was a problem hiding this comment.
It's assumed that the i-th element in sources corresponds to the i-th element in targets, representing a directed edge from source to target. Is this assumption reasonable? Please add a comment for the same.
| return "OTHER" | ||
|
|
||
| def build_database_entry(config, db_name): | ||
| """Builds a database entry, mimicking the successful Oracle format.""" |
Collaborator
There was a problem hiding this comment.
nit: Remove such comments.
| @@ -0,0 +1,93 @@ | |||
| # AWS Glue to Google Cloud Dataplex Connector | |||
Collaborator
There was a problem hiding this comment.
Please include following info:
- Metadata extracted: example https://github.com/GoogleCloudPlatform/cloud-dataplex/tree/main/managed-connectivity/community-contributed-connectors/oracle-connector#target-objects-and-schemas
- How to fetch AWS credentials if non-trivial
- What resources need to be created in the project for import: example https://github.com/GoogleCloudPlatform/cloud-dataplex/tree/main/managed-connectivity/community-contributed-connectors/oracle-connector#target-objects-and-schemas
- Docker setup: https://github.com/GoogleCloudPlatform/cloud-dataplex/tree/main/managed-connectivity/community-contributed-connectors/oracle-connector#target-objects-and-schemas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code for AWS Glue to Dataplex connector code