chore(deps): update module github.com/go-git/go-git/v5 to v5.16.5 [security]#3358
Conversation
|
/gcbrun |
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a crucial dependency upgrade for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the github.com/go-git/go-git/v5 dependency from v5.16.4 to v5.16.5 to address the security vulnerability CVE-2026-25934. The changes in go.mod and go.sum are correct and necessary. This is a straightforward and important update.
1ead11e to
73b63bc
Compare
|
/gcbrun |
73b63bc to
3955b21
Compare
|
/gcbrun |
This PR contains the following updates:
v5.16.4→v5.16.5GitHub Vulnerability Alerts
CVE-2026-25934
Impact
A vulnerability was discovered in
go-gitwhereby data integrity values for.packand.idxfiles were not properly verified. This resulted ingo-gitpotentially consuming corrupted files, which would likely result in unexpected errors such asobject not found.For context, clients fetch
packfilesfrom upstream Git servers. Those files contain a checksum of their contents, so that clients can perform integrity checks before consuming it. The pack indexes (.idx) are generated locally bygo-git, or thegitcli, when new.packfiles are received and processed. The integrity checks for both files were not being verified correctly.Note that the lack of verification of the packfile checksum has no impact on the trust relationship between the client and server, which is enforced based on the protocol being used (e.g. TLS in the case of
https://or known hosts forssh://). In other words, the packfile checksum verification does not provide any security benefits when connecting to a malicious or compromised Git server.Patches
Users should upgrade to
v5.16.5, or the latestv6pseudo-version, in order to mitigate this vulnerability.Workarounds
In case updating to a fixed version of
go-gitis not possible, users can run git fsck from thegitcli to check for data corruption on a given repository.Credit
Thanks @N0zoM1z0 for finding and reporting this issue privately to the
go-gitproject.Release Notes
go-git/go-git (github.com/go-git/go-git/v5)
v5.16.5Compare Source
What's Changed
Full Changelog: go-git/go-git@v5.16.4...v5.16.5
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.