Skip to content

Conversation

@zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Jun 8, 2023

Attempt to upgrade to R2DBC SPI 1.0 #487

This is a draft PR intent to estimate upgrade effort.

Change in r2dbc:
io.r2dbc.spi.Result$getRowsUpdated() now returns Publisher<Long> instead of Publisher<Integer>
r2dbc/r2dbc-spi@03977f5, r2dbc/r2dbc-spi#255

  • Fixed compiling errors
  • Fixed unit test errors
  • integration test errors caused by return type change Integer -> Long

error log

[ERROR] Failures: 
[ERROR]   ClientLibraryBasedIntegrationTest.insertMultipleBoundParameterSetsInTransaction expectation "expectNext(1)" failed (expected value: 1; actual value: 1)
[ERROR]   ClientLibraryBasedIntegrationTest.selectQueryReturnsUpdatedDataDuringAndAfterTransactionCommit expectation "expectNext(1)" failed (expected value: 1; actual value: 1)
[ERROR]   ClientLibraryBasedIntegrationTest.selectQueryReturnsUpdatedDataDuringTransactionButNotAfterTransactionRollback expectation "expectNext(1)" failed (expected value: 1; actual value: 1)
[ERROR]   ClientLibraryBasedIntegrationTest.testStaleRead expectation "row inserted" failed (expected value: 1; actual value: 1)
[ERROR]   ClientLibraryBasedIntegrationTest.testStrongReadFromSubclassedConnection expectation "row inserted" failed (expected value: 1; actual value: 1)
[ERROR]   ClientLibraryBasedIntegrationTest.testTransactionFollowedByStandaloneStatementCommitted expectation "expectNext(1)" failed (expected value: 1; actual value: 1)
[ERROR]   ClientLibraryBasedIntegrationTest.testTransactionMultipleStatementsCommitted expectation "expectNext(1)" failed (expected value: 1; actual value: 1)
[ERROR]   ClientLibraryBasedIntegrationTest.testTransactionRolledBack expectation "expectNext(1)" failed (expected value: 1; actual value: 1)
[ERROR]   ClientLibraryBasedIntegrationTest.testTransactionSingleStatementCommitted expectation "expectNext(1)" failed (expected value: 1; actual value: 1)
[INFO] 
[ERROR] Tests run: 60, Failures: 9, Errors: 0, Skipped: 34

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant