chore: add checks for server ca certificates in refresh.go#1037
Merged
Conversation
enocom
approved these changes
Oct 24, 2025
Member
enocom
left a comment
enocom
left a comment
There was a problem hiding this comment.
LGTM.
From an API perspective, is this an acceptable state?
Contributor
Author
The API does not return server CA cert while creation (the first minute of it) |
panavenue
approved these changes
Oct 24, 2025
hessjcg
approved these changes
Oct 27, 2025
panavenue
pushed a commit
that referenced
this pull request
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses a panic that can occur during the refresh operation if the server CA certificate is not available in the instance metadata.
A nil check is added to validate the server CA certificate before it is used. If the certificate is nil, a refresh error is now returned instead of causing a panic from a nil pointer dereference.
Fixes: #1032