System metrics setup#1041
Merged
panavenue merged 11 commits intofeature/client-side-metricsfrom Dec 5, 2025
Merged
Conversation
8747506 to
1f835d8
Compare
1f835d8 to
ad4a6e6
Compare
enocom
reviewed
Nov 14, 2025
Member
enocom
left a comment
There was a problem hiding this comment.
Glad to see the AlloyDB implementation was helpful. Left a couple of comments.
enocom
reviewed
Nov 24, 2025
hessjcg
reviewed
Dec 2, 2025
hessjcg
reviewed
Dec 2, 2025
|
|
||
| // Resolve the instance connection name to a ConnName struct. | ||
| // Note: icn may be a domain name that resolves to an instance connection name. | ||
| cn, err := d.resolver.Resolve(ctx, icn) |
Collaborator
There was a problem hiding this comment.
We should count DNS lookup successes and errors. Does this make more sense as a label on our connect count metric, or is DNS resolution + status its own separate counter.
Collaborator
Author
There was a problem hiding this comment.
Oh good call! I don't think I have any DNS lookup/resolve metric in my design doc yet. I will add this one to the doc.
I think having a separate counter would be better. WDYT?
enocom
reviewed
Dec 3, 2025
Member
enocom
left a comment
There was a problem hiding this comment.
LGTM -- except you're missing the option to disable metrics.
enocom
reviewed
Dec 3, 2025
enocom
approved these changes
Dec 3, 2025
kgala2
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description - This pull request introduces a comprehensive system for collecting and exporting client-side metrics from the Cloud SQL Go Connector, providing valuable insights into the connector's performance and behavior. The key changes include the integration of OpenTelemetry for metrics collection and the introduction of a dedicated telemetry package.
telwith new metrics -