fix: Check all containers and init containers for proxy before recreating pod #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
approved these changes
Apr 22, 2025
hessjcg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the controller is now using sidecar init containers, these should be checked for existence when determining if a pod needs to be recreated because the proxy injection failed. In other words, currently we get false positives if the main workload is erroring and the proxy was injected as a sidecar init container, which causes the controller to remove the pod instead of letting it progress.
I ran into some errors running the go_lint step in the Makefile (even before making changes) and ran into a problem during the terraform execution of building the infra for the e2e tests, so I wasn't able to complete them as laid out in the docs. I did however remove the go_lint step, build the controller image and replace it in my cluster and confirmed the desired effect.