Skip to content

Conversation

@jackwotherspoon
Copy link
Collaborator

@jackwotherspoon jackwotherspoon commented Jun 4, 2024

Today, the Python Connector for async usage does not allow being called across
multiple event loops.

However, we do not explicitly define that logic nor make it clear via an error message.

This PR adds an error message to check in connect_async if the Connector._loop
attribute matches the current running event loop and errors if it does not (multiple event loops).

Related to #1107

@jackwotherspoon jackwotherspoon self-assigned this Jun 4, 2024
@jackwotherspoon jackwotherspoon marked this pull request as ready for review October 1, 2024 17:24
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner October 1, 2024 17:24
Copy link
Collaborator

@kgala2 kgala2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hessjcg hessjcg merged commit 3030b82 into main Sep 29, 2025
17 checks passed
@hessjcg hessjcg deleted the error-on-loop branch September 29, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants