refactor: allow cert chain for server cert #1165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it is slightly interesting that the integration for this already was passing. I guess having an intermediate cert and chain of trust is maybe optional? @hessjcg do you know if chain of trust is optional here? |
|
From chatting with @feng-zhe offline I now realize that this will not be a list and will still be a single string, no change is needed in the library to handle the chain of trust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAS-based CA instances can have a chain of trust.
Should allow server CA to be a list of certs to allow this cert chain.
This was part of #1154 that was closed.