chore: update type hints to standard collections #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
approved these changes
Oct 25, 2024
rhatgadkar-goog
added a commit
to GoogleCloudPlatform/alloydb-python-connector
that referenced
this pull request
Jan 9, 2025
This change is analogous to CloudSQL's change: GoogleCloudPlatform/cloud-sql-python-connector#1183
rhatgadkar-goog
added a commit
to GoogleCloudPlatform/alloydb-python-connector
that referenced
this pull request
Jan 9, 2025
This change is analogous to CloudSQL's change: GoogleCloudPlatform/cloud-sql-python-connector#1183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates type hints to use standard collections (
list,tuple,dict).We can do this now that Python 3.8 was removed
As of Python 3.9 and PEP 585 standard collections can be subscripted in
favor of their
typingcounterparts which are now deprecated.