Skip to content

Conversation

@jackwotherspoon
Copy link
Collaborator

Validate domain names are properly formatted via regex for better error handling.

Closes #1245

@jackwotherspoon jackwotherspoon self-assigned this Mar 18, 2025
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner March 18, 2025 15:00
@jackwotherspoon
Copy link
Collaborator Author

Need to look into warning:

connection_name.py:24: SyntaxWarning: invalid escape sequence '\.'
    "^(?:[_a-z0-9](?:[_a-z0-9-]{0,61}[a-z0-9])?\.)+(?:[a-z](?:[a-z0-9-]{0,61}[a-z0-9])?)?$"

@jackwotherspoon
Copy link
Collaborator Author

Need to look into warning:

connection_name.py:24: SyntaxWarning: invalid escape sequence '\.'
    "^(?:[_a-z0-9](?:[_a-z0-9-]{0,61}[a-z0-9])?\.)+(?:[a-z](?:[a-z0-9-]{0,61}[a-z0-9])?)?$"

Duh, can't use \ in Python string, updated to use raw string to keep slash.

@jackwotherspoon jackwotherspoon merged commit 15934bd into main Mar 19, 2025
15 checks passed
@jackwotherspoon jackwotherspoon deleted the domain-name-validation branch March 19, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add domain name validation to Python Connector

3 participants