Skip to content

fix: Use either x509.not_valid_after_utc or if it does not exist, x509.not_valid_after #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Use either x509.not_valid_after_utc or if it does not exist, x509.not_valid_after #1307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion google/cloud/sql/connector/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,14 @@ async def _get_ephemeral(
x509 = load_pem_x509_certificate(
ephemeral_cert.encode("UTF-8"), default_backend()
)
expiration = x509.not_valid_after_utc

if 'not_valid_after_utc' in x509:
expiration = x509.not_valid_after_utc
elif 'not_valid_after' in x509:
expiration = x509.not_valid_after
else:
expiration = datetime.MINYEAR

# for IAM authentication OAuth2 token is embedded in cert so it
# must still be valid for successful connection
if enable_iam_auth:
Expand Down
Loading