Add Fractional GPU Support For G4

[LAVEEN]

This PR introduces a fracitonal GPU support For G4 Series.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

• Fork your PR branch from the Toolkit "develop" branch (not main)
• Test all changes with pre-commit in a local branch #
• Confirm that "make tests" passes all tests
• Add or modify unit tests to cover code changes
• Ensure that unit test coverage remains above 80%
• Update all applicable documentation
• Follow Cluster Toolkit Contribution guidelines #

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the GPU definition module by incorporating support for fractional GPU units on G4 series instances. This change allows for more efficient and flexible allocation of GPU resources, particularly for workloads that do not require a full GPU, thereby optimizing cost and resource utilization within the infrastructure.

Highlights

• Fractional GPU Support: Introduced support for fractional GPU allocation for G4 series instances, enabling more granular resource management.
• New G4 Instance Definitions: Added g4-standard-6, g4-standard-12, and g4-standard-24 instance types with fractional GPU counts (0.125, 0.25, and 0.5 respectively) to the GPU definition configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to add fractional GPU support for G4 series machine types. However, the current implementation uses fractional values for the count attribute of the guest accelerator, which is incorrect. The Terraform provider for both GKE node pools and Compute Engine instances expects an integer for the number of physical GPUs. This will cause the deployment to fail.

Additionally, the pull request is missing a few key elements required by the project's contribution guidelines:

• The PR description does not explain how these changes were tested.
• The project's documentation, specifically docs/gpu-support.md, has not been updated. The document incorrectly states that GPU automation is only supported for the a2 machine family, while it now covers a2, a3, g2, and g4 families.