Adding kueue support for GKE A4X-Max

[vikramvs-gg]

Feat: Adding kueue support for GKE A4X-Max

This PR adds kueue support for GKE A4X-Max. A kueue configuration manifest is added along with defined topologies of block, subblock and host levels. Kueue version is 0.14.4. Corresponding annotation of subblock topology is used in the NCCL jobset.
This PR also upgrades the asapd-lite container image version from 0.0.3 to 0.0.7 because the older version did not recognize the newer firmware installed on A4X-Max bare metal nodes.
We are also removing the additional_networks from gke-cluster in blueprint, keeping it on the node-pool. Machine type a4x-maxgpu-4g-metal is not supported when multi-networking is enabled on the cluster.

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

• Fork your PR branch from the Toolkit "develop" branch (not main)
• Test all changes with pre-commit in a local branch #
• Confirm that "make tests" passes all tests
• Add or modify unit tests to cover code changes
• Ensure that unit test coverage remains above 80%
• Update all applicable documentation
• Follow Cluster Toolkit Contribution guidelines #

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the GKE A4X-Max bare metal example by integrating Kueue for advanced job scheduling and resource management, ensuring optimal utilization of GPU resources. It also addresses a critical compatibility issue by updating the asapd-lite image to support newer firmware and refactors network configurations to resolve conflicts with specific machine types.

Highlights

• Kueue Integration: Added Kueue support for GKE A4X-Max, including a new configuration manifest that defines block, subblock, and host topologies. The Kueue version is set to 0.14.4.
• Image Upgrade: Upgraded the asapd-lite container image from v0.0.3 to v0.0.7 to ensure compatibility with newer firmware on A4X-Max bare metal nodes.
• Network Configuration Adjustment: Removed additional_networks from the GKE cluster blueprint and moved it to the node-pool level, addressing an incompatibility where the a4x-maxgpu-4g-metal machine type does not support multi-networking when enabled at the cluster level.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces Kueue support for the GKE A4X-Max example, which is a valuable addition. The changes include adding the necessary Kueue configuration, updating the example blueprint to install and configure Kueue, and modifying the NCCL jobset example to use it. The upgrade of the asapd-lite image and the adjustment to the additional_networks configuration are also well-justified.

My review has identified one critical issue where the specified Kueue version is not yet supported by the kubectl-apply module, which will cause deployment failures. Please see the specific comment for details on how to resolve this.