Skip to content

enable execution of external prolog/epilog for A4X#5403

Merged
Neelabh94 merged 1 commit intoGoogleCloudPlatform:developfrom
Neelabh94:a4x_prolog_fix
Mar 27, 2026
Merged

enable execution of external prolog/epilog for A4X#5403
Neelabh94 merged 1 commit intoGoogleCloudPlatform:developfrom
Neelabh94:a4x_prolog_fix

Conversation

@Neelabh94
Copy link
Copy Markdown
Contributor

The PR adds enable_external_prolog_epilog: true flag to the a4xhigh-slurm-blueprint.yaml.

Why it should be enabled

The blueprint is already staging several critical scripts via the controller_scripts section into the /opt/apps/adm/slurm directory:

imex_prolog / imex_epilog: Required for NVIDIA IMEX (Interrupt Management and Execution) support.
gpu-test: A cluster health check to ensure GPUs are functional before/after jobs.
sudo-oslogin: Enables passwordless sudo for authorized users.

Without this flag, while these scripts are successfully downloaded and placed on the disk, Slurm will never execute them because the necessary "multiplexer" infrastructure and Slurm configuration changes are not applied.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical configuration oversight in the A4X high-GPU blueprint by activating a flag that ensures the proper execution of essential Slurm scripts. This activation guarantees that vital system functionalities, including GPU health monitoring and NVIDIA IMEX support, are correctly integrated and operational within the Slurm environment, thereby enhancing the overall stability and performance of the system.

Highlights

  • External Prolog/Epilog Activation: The enable_external_prolog_epilog: true flag has been added to the a4xhigh-slurm-blueprint.yaml configuration. This change is crucial for enabling Slurm to execute pre-staged critical scripts, such as imex_prolog, imex_epilog, gpu-test, and sudo-oslogin, which are necessary for NVIDIA IMEX support, GPU health checks, and passwordless sudo functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a configuration change to enable external prolog/epilog for the a4x-highgpu-4g Slurm blueprint. The review suggests an improvement to enhance configurability and maintainability by defining enable_external_prolog_epilog as a variable in the vars section, allowing users to easily enable or disable this feature without modifying the core blueprint.

@Neelabh94 Neelabh94 added the release-bugfix Added to release notes under the "Bug fixes" heading. label Mar 25, 2026
@Neelabh94 Neelabh94 marked this pull request as ready for review March 25, 2026 12:47
@Neelabh94 Neelabh94 requested review from a team and samskillman as code owners March 25, 2026 12:47
@Neelabh94 Neelabh94 merged commit 19c4a93 into GoogleCloudPlatform:develop Mar 27, 2026
17 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants