Skip to content

fix(deduplication): A4x-max (slurm) bare metal prolog/epilog scripts#5404

Draft
Neelabh94 wants to merge 1 commit intoGoogleCloudPlatform:developfrom
Neelabh94:a4x-bm-prolog-fix
Draft

fix(deduplication): A4x-max (slurm) bare metal prolog/epilog scripts#5404
Neelabh94 wants to merge 1 commit intoGoogleCloudPlatform:developfrom
Neelabh94:a4x-bm-prolog-fix

Conversation

@Neelabh94
Copy link
Copy Markdown
Contributor

@Neelabh94 Neelabh94 commented Mar 25, 2026

This PR removes the duplicated embedding of the prolog/epilog script in the SLURM A4X BareMetal blueprint and standardizes the process by utilizing the external prolog/epilog scripts, which were being already fetched from slurm-gcp using curl.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@Neelabh94 Neelabh94 changed the base branch from main to develop March 25, 2026 13:44
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the a4xmax-bm-slurm-blueprint.yaml by replacing inline IMEX prolog and epilog scripts with a reference to a controller_startup_script and enabling external prolog/epilog functionality. Feedback indicates a critical issue with a duplicated controller_startup_script key in the YAML, which needs to be resolved to prevent unexpected behavior. Additionally, the slurm_controller module's use block requires an update to include controller_startup to comply with the repository's style guide regarding explicit module dependencies.

@Neelabh94 Neelabh94 changed the title fix(deduplication): A4x (slurm) bare metal prolog/epilog scripts fix(deduplication): A4x-max (slurm) bare metal prolog/epilog scripts Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant