fix(deduplication): A4x-max (slurm) bare metal prolog/epilog scripts#5404
Draft
Neelabh94 wants to merge 1 commit intoGoogleCloudPlatform:developfrom
Draft
fix(deduplication): A4x-max (slurm) bare metal prolog/epilog scripts#5404Neelabh94 wants to merge 1 commit intoGoogleCloudPlatform:developfrom
Neelabh94 wants to merge 1 commit intoGoogleCloudPlatform:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the a4xmax-bm-slurm-blueprint.yaml by replacing inline IMEX prolog and epilog scripts with a reference to a controller_startup_script and enabling external prolog/epilog functionality. Feedback indicates a critical issue with a duplicated controller_startup_script key in the YAML, which needs to be resolved to prevent unexpected behavior. Additionally, the slurm_controller module's use block requires an update to include controller_startup to comply with the repository's style guide regarding explicit module dependencies.
examples/machine-learning/a4x-maxgpu-4g-metal/a4xmax-bm-slurm-blueprint.yaml
Outdated
Show resolved
Hide resolved
examples/machine-learning/a4x-maxgpu-4g-metal/a4xmax-bm-slurm-blueprint.yaml
Outdated
Show resolved
Hide resolved
f256f5e to
3f96cb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the duplicated embedding of the prolog/epilog script in the SLURM A4X BareMetal blueprint and standardizes the process by utilizing the external prolog/epilog scripts, which were being already fetched from slurm-gcp using curl.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.