Remove chs v1 manifest files and update example blueprints#5415
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request removes the deprecated Cluster Health Scanner (CHS) v1 manifest templates and their associated configurations from several example blueprints. The changes streamline the example deployments by eliminating unused resources and variables, ensuring the codebase remains clean and up-to-date with current standards. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the Cluster Health Scanner (CHS) functionality across several GKE blueprints, specifically for A3 Mega, A3 Ultra, and A4 configurations. The changes include the deletion of multiple template files for Kubernetes CronJobs, ServiceAccounts, RBAC roles, and PersistentVolumeClaims used for health monitoring. Correspondingly, the enable_periodic_health_checks and health_check_schedule variables, along with their associated manifest application blocks, have been stripped from the blueprint YAML files. I have no feedback to provide.
shubpal07
left a comment
There was a problem hiding this comment.
LGTM.
Needs a follow-up updation of cloud docs
8d059f9
into
GoogleCloudPlatform:develop
This PR removes the CHS v1 manifest template files and yamls since their use has been deprecated.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.