Skip to content

Remove chs v1 manifest files and update example blueprints#5415

Merged
agrawalkhushi18 merged 1 commit intoGoogleCloudPlatform:developfrom
agrawalkhushi18:chs-cleanup
Mar 30, 2026
Merged

Remove chs v1 manifest files and update example blueprints#5415
agrawalkhushi18 merged 1 commit intoGoogleCloudPlatform:developfrom
agrawalkhushi18:chs-cleanup

Conversation

@agrawalkhushi18
Copy link
Copy Markdown
Contributor

This PR removes the CHS v1 manifest template files and yamls since their use has been deprecated.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request removes the deprecated Cluster Health Scanner (CHS) v1 manifest templates and their associated configurations from several example blueprints. The changes streamline the example deployments by eliminating unused resources and variables, ensuring the codebase remains clean and up-to-date with current standards.

Highlights

  • Deprecation of CHS v1: Removed all Cluster Health Scanner (CHS) v1 manifest templates and associated YAML configuration files across multiple example blueprints.
  • Configuration Cleanup: Updated example deployment files to remove variables and settings related to periodic health checks, cleaning up the configuration surface.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Cluster Health Scanner (CHS) functionality across several GKE blueprints, specifically for A3 Mega, A3 Ultra, and A4 configurations. The changes include the deletion of multiple template files for Kubernetes CronJobs, ServiceAccounts, RBAC roles, and PersistentVolumeClaims used for health monitoring. Correspondingly, the enable_periodic_health_checks and health_check_schedule variables, along with their associated manifest application blocks, have been stripped from the blueprint YAML files. I have no feedback to provide.

@agrawalkhushi18 agrawalkhushi18 marked this pull request as ready for review March 27, 2026 04:47
@agrawalkhushi18 agrawalkhushi18 requested review from a team and samskillman as code owners March 27, 2026 04:47
@agrawalkhushi18 agrawalkhushi18 added release-chore To not include into release notes release-deprecations Added to release notes under the "Deprecations" heading. labels Mar 27, 2026
Copy link
Copy Markdown
Contributor

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@shubpal07 shubpal07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Needs a follow-up updation of cloud docs

@agrawalkhushi18 agrawalkhushi18 merged commit 8d059f9 into GoogleCloudPlatform:develop Mar 30, 2026
18 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes release-deprecations Added to release notes under the "Deprecations" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants