feat: Add explicit opt-in Quota Availability Validator#5422
feat: Add explicit opt-in Quota Availability Validator#5422kvenkatachala333 wants to merge 2 commits intoGoogleCloudPlatform:developfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a new, optional validator to the Cluster Toolkit designed to proactively check resource availability against GCP quotas. By integrating directly with the Compute Engine Quotas API, it provides a 'fail-fast' mechanism that helps users identify potential deployment blockers early. The implementation is designed to be non-intrusive, ensuring that existing workflows remain unaffected unless the validator is explicitly enabled in the blueprint. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new quota availability validator for GCP resources, including support for CPUs, GPUs, Disks, Filestore, and TPUs. The implementation includes a new GCPQuotaClient with retry logic and caching, along with comprehensive unit tests. Feedback is provided regarding the optimization of the accelerator metric map by moving it to a package-level variable and improving error handling when evaluating TPU preemption settings to avoid silent failures on unknown values.
This PR introduces a Quota Availability Validator to the Cluster Toolkit as an explicit, opt-in feature. It enables a "fail fast" mechanism by verifying resource capacity before deployment, without causing regressions or unexpected latency for existing blueprints.
Key Features
How to Enable in Blueprint
Resource Coverage
Resiliency & Performance