Skip to content

fix: prevent munge startup race on compute node boot #5423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mtibben wants to merge 3 commits into
base: develop
Choose a base branch
from
+20 −0
Draft

fix: prevent munge startup race on compute node boot #5423

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b039ccc
fix: prevent munge startup race on compute node boot
mtibben Mar 30, 2026
4542d69
fix: use dirs.munge to reference munge key path
mtibben Mar 30, 2026
6f554bf
fix: extend munge boot race fix to login nodes
mtibben Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...ty/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,19 @@ def setup_controller():
pass


def prevent_munge_boot_race():
"""Install a systemd drop-in so munge.service is skipped (not failed) at
boot when munge.key is absent, and clear any failed state from the current
boot before setup_network_storage() deploys the key."""
munge_override_dir = Path("/etc/systemd/system/munge.service.d")
munge_override_dir.mkdir(parents=True, exist_ok=True)
(munge_override_dir / "require-key.conf").write_text(
f"[Unit]\nConditionPathExists={dirs.munge / 'munge.key'}\n"
)
run("systemctl daemon-reload", timeout=30)
run("systemctl reset-failed munge", timeout=30, check=False)


def setup_login():
"""run login node setup"""
log.info("Setting up login")
Expand All @@ -509,6 +522,9 @@ def setup_login():
update_system_config("sackd", sysconf)
install_custom_scripts()

if not lkp.cfg.enable_slurm_auth:
prevent_munge_boot_race()

setup_network_storage()
setup_sudoers()
if not lkp.cfg.enable_slurm_auth:
Expand Down Expand Up @@ -554,6 +570,10 @@ def setup_compute():
install_custom_scripts()

setup_nss_slurm()

if not lkp.cfg.enable_slurm_auth:
prevent_munge_boot_race()

setup_network_storage()

has_gpu = run("lspci | grep --ignore-case 'NVIDIA' | wc -l", shell=True).returncode
Expand Down
Loading