Skip to content

Revert:Use N4 (gen4) machines as default to create GKE system nodepool#5425

Merged
aslam-quad merged 1 commit intoGoogleCloudPlatform:developfrom
aslam-quad:revert-5402-fix/e2-n4
Mar 30, 2026
Merged

Revert:Use N4 (gen4) machines as default to create GKE system nodepool#5425
aslam-quad merged 1 commit intoGoogleCloudPlatform:developfrom
aslam-quad:revert-5402-fix/e2-n4

Conversation

@aslam-quad
Copy link
Copy Markdown
Contributor

@aslam-quad aslam-quad commented Mar 30, 2026

Reverts #5402

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@aslam-quad aslam-quad requested review from a team and samskillman as code owners March 30, 2026 05:16
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous change that updated the default machine type for the GKE system node pool. The configuration is being rolled back to use the previous standard machine type to ensure compatibility or stability as required by the current environment.

Highlights

  • Revert Machine Type: Reverted the default machine type for the GKE system node pool from 'n4-standard-4' back to 'e2-standard-4'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the external PR from external contributor label Mar 30, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default machine type for the system node pool in the GKE cluster module from n4-standard-4 to e2-standard-4. The change is consistently applied to both the Terraform variable definition and the module's README documentation. I have no feedback to provide.

@aslam-quad aslam-quad added the release-chore To not include into release notes label Mar 30, 2026
@aslam-quad aslam-quad merged commit de18848 into GoogleCloudPlatform:develop Mar 30, 2026
13 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants