Skip to content

refactor: Fix pre-commit error in kubectl-apply#5427

Open
jamOne- wants to merge 1 commit intoGoogleCloudPlatform:developfrom
jamOne-:fix-kubectl-apply-null-source
Open

refactor: Fix pre-commit error in kubectl-apply#5427
jamOne- wants to merge 1 commit intoGoogleCloudPlatform:developfrom
jamOne-:fix-kubectl-apply-null-source

Conversation

@jamOne-
Copy link
Copy Markdown

@jamOne- jamOne- commented Mar 30, 2026

Fix the following error

  on ../../management/kubectl-apply/main.tf line 65, in locals:
  65:     if try(manifest.source, null) != null && (startswith(manifest.source, "http://") || startswith(manifest.source, "https://"))

with manifest.source set to null.

Invalid value for "str" parameter: argument must not be null.

Error: Invalid function argument

@jamOne- jamOne- requested review from a team and samskillman as code owners March 30, 2026 09:21
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a runtime error in the Terraform configuration where the startswith function was receiving a null argument. By leveraging the try function, the logic now safely evaluates URL patterns without crashing when the manifest source is missing.

Highlights

  • Error Handling: Updated the logic for identifying URL-based manifests to prevent Terraform errors when the source attribute is null.
  • Refactoring: Wrapped the startswith function calls within a try block to gracefully handle null values instead of explicitly checking for non-null sources.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the external PR from external contributor label Mar 30, 2026
@jamOne- jamOne- changed the title Fix invalid function argument in kubectl-apply startswith refactor: Fix pre-commit error in kubectl-apply Mar 30, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the logic for identifying URL-based manifests in the kubectl-apply module by using a try block to handle potential null values or errors in the startswith function. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant