Skip to content

Fix invalid resource name and add period to end of DNS names #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gibbleyg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix invalid resource name and add period to end of DNS names #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d5b628
Fix invalid resource name and add period to end of DNS names
gibbleyg Jul 27, 2021
a891020
Fix all_supported_record_types DNS records
gibbleyg Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions google/resource-snippets/dns-v1/all_supported_record_types.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ resources:
- name: rrset-template-1
type: all_supported_record_types.jinja
properties:
rrsetDomain: dm-testing-all-record-types.com
rrsetName: dm_testing_rrset_1
zoneDnsName: dm-testing-all-record-types.com
zoneName: dm_testing_zone_1
rrsetDomain: dm-testing-all-record-types.com.
rrsetName: dm-testing-rrset-1
zoneDnsName: dm-testing-all-record-types.com.
zoneName: dm-testing-zone-1
version: v1
8 changes: 4 additions & 4 deletions google/resource-snippets/dns-v1/one_a_record.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ resources:
- name: rrset-template-1
type: one_a_record.jinja
properties:
rrsetDomain: dm-testing-a-record.com
rrsetName: dm_testing_rrset_1
zoneDnsName: dm-testing-a-record.com
zoneName: dm_testing_zone_1
rrsetDomain: dm-testing-a-record.com.
rrsetName: dm-testing-rrset-1
zoneDnsName: dm-testing-a-record.com.
zoneName: dm-testing-zone-1
version: v1