Skip to content

chore: Drop notify on failure, update deps #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2024
Merged

chore: Drop notify on failure, update deps #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e88279
Drop notify on failure
kevmoo Dec 8, 2024
a9eefe7
bump generated output
kevmoo Dec 8, 2024
766c249
fix tests
kevmoo Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,21 +473,3 @@ jobs:
run: flutter analyze
if: "always() && steps.examples_fullstack_frontend_pub_upgrade.conclusion == 'success'"
working-directory: examples/fullstack/frontend
job_007:
name: Notify failure
runs-on: ubuntu-latest
if: "(github.event_name == 'push' || github.event_name == 'schedule') && failure()"
steps:
- run: |
curl -H "Content-Type: application/json" -X POST -d \
"{'text':'Build failed! ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}'}" \
"${CHAT_WEBHOOK_URL}"
env:
CHAT_WEBHOOK_URL: "${{ secrets.CHAT_WEBHOOK_URL }}"
needs:
- job_001
- job_002
- job_003
- job_004
- job_005
- job_006
19 changes: 0 additions & 19 deletions .github/workflows/unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,22 +359,3 @@ jobs:
run: dart test
if: "always() && steps.google_cloud_pub_upgrade.conclusion == 'success'"
working-directory: google_cloud
job_008:
name: Notify failure
runs-on: ubuntu-latest
if: "(github.event_name == 'push' || github.event_name == 'schedule') && failure()"
steps:
- run: |
curl -H "Content-Type: application/json" -X POST -d \
"{'text':'Build failed! ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}'}" \
"${CHAT_WEBHOOK_URL}"
env:
CHAT_WEBHOOK_URL: "${{ secrets.CHAT_WEBHOOK_URL }}"
needs:
- job_001
- job_002
- job_003
- job_004
- job_005
- job_006
- job_007
34 changes: 13 additions & 21 deletions functions_framework/lib/src/cloud_event.g.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion functions_framework/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ dev_dependencies:
build_runner: ^2.2.1
build_verify: ^3.0.0
dart_flutter_team_lints: ^3.0.0
json_serializable: ^6.6.0
json_serializable: ^6.9.0
test: ^1.21.6
4 changes: 2 additions & 2 deletions integration_test/test/cli_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ void main() {
await expectLater(
proc.stderr,
emitsInOrder([
'Could not find an option named "bob".',
'Could not find an option named "--bob".',
...LineSplitter.split(_usage),
]),
);
Expand Down Expand Up @@ -193,7 +193,7 @@ void main() {
await expectLater(
proc.stderr,
emitsInOrder([
'"foo" is not an allowed value for option "signature-type".',
'"foo" is not an allowed value for option "--signature-type".',
...LineSplitter.split(_usage),
]),
);
Expand Down
13 changes: 0 additions & 13 deletions mono_repo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,3 @@ github:
name: Dart Unit CI
stages:
- unit_test

on_completion:
- name: "Notify failure"
runs-on: ubuntu-latest
# Run only if other jobs have failed and this is a push or scheduled build.
if: (github.event_name == 'push' || github.event_name == 'schedule') && failure()
steps:
- run: >
curl -H "Content-Type: application/json" -X POST -d \
"{'text':'Build failed! ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}'}" \
"${CHAT_WEBHOOK_URL}"
env:
CHAT_WEBHOOK_URL: ${{ secrets.CHAT_WEBHOOK_URL }}
Loading