fix(deps): update dependency org.springframework.boot:spring-boot-starter-web to v4 #1256
Conversation
forking-renovate
bot
added
the
automerge
trusted-contributions-gcf
bot
added
the
kokoro:force-run
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical maintenance task: upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
kokoro-team
removed
the
kokoro:force-run
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request attempts to upgrade spring-boot-starter-web to version 4.0.0. This is a problematic update because version 4.0.0 of Spring Boot has not been released, which will cause build failures. Furthermore, the project is configured for Java 8, which is incompatible with Spring Boot 3.x and higher (which require Java 17+). I've left a comment suggesting a downgrade to a compatible Spring Boot 2.7.x version to resolve these critical issues.
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-web</artifactId> | ||
| <version>3.1.1</version> | ||
| <version>4.0.0</version> |
There was a problem hiding this comment.
This update to Spring Boot 4.0.0 is problematic for several reasons:
- Non-existent Version: Spring Boot
4.0.0is not a released version. This will cause the Maven build to fail as it cannot resolve this dependency. - Java Version Incompatibility: This project is configured to use Java 8 (
<java.version>1.8</java.version>). Spring Boot 3.x (including the previous version3.1.1) requires a minimum of Java 17. A future Spring Boot 4.x would require an even newer Java version. - Project Context: The project is named
kotlin-sb-appengine-standardand is located underappengine-standard-java8, indicating it's targeted for the App Engine Java 8 standard environment. This environment does not support Java 17+.
Given these points, the project should be using a version of Spring Boot compatible with Java 8, such as the 2.7.x line. I suggest downgrading to the latest version in that line to fix the existing incompatibility and make the project buildable.
| <version>4.0.0</version> | |
| <version>2.7.18</version> |
3 participants
This PR contains the following updates:
3.1.1->4.0.0Release Notes
spring-projects/spring-boot (org.springframework.boot:spring-boot-starter-web)
v4.0.0v3.5.8v3.5.7⭐ New Features
🐞 Bug Fixes
📔 Documentation
@Beanannotation #47330🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@DKARAGODIN, @JinhyeokFang, @Lublanski, @Pankraz76, @fhiyo, @ngocnhan-tran1996, @nosan, @scottfrederick, and @xyraclius
v3.5.6🐞 Bug Fixes
📔 Documentation
🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@Chanwon-Seo, @doljae, @izeye, and @quaff
v3.5.5Compare Source
🐞 Bug Fixes
@Name#46666@Namewith a constructor-bound property #46663@FilterRegistrationannotation #46605📔 Documentation
@returns#46769🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@Kguswo, @deejay1, @ganjisriver, @izeye, @jetflo, @ngocnhan-tran1996, @nicolasgarea, @nosan, @prishedko, @quaff, @schmidti159, @scordio, @shakuzen, @tommyk-gears, @zahra7, and @zakaria-shahen
v3.5.4Compare Source
🐞 Bug Fixes
📔 Documentation
🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@Dockerel, @PiyalAhmed, @benelog, @dmitrysulman, @izeye, @ngocnhan-tran1996, @nosan, and @quaff
v3.5.3Compare Source
🐞 Bug Fixes
v3.5.2Compare Source
🐞 Bug Fixes
v3.5.1Compare Source
multipart/form-datarequests. These limits can be customized usingserver.tomcat.max-part-countandserver.tomcat.max-part-header-sizerespectively.⭐ New Features
🐞 Bug Fixes
@WebMvcTest#45666📔 Documentation
🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@Peksa, @Rutujakolte03, @chanbinme, @csbiy, @davidlj95, @izeye, @juliojgd, @ngocnhan-tran1996, @nicolasgarea, @nosan, @quaff, @shekharAggarwal, @tanruian, and @wonyongg
v3.5.0Compare Source
Full release notes for Spring Boot 3.5 are available on the wiki.
⭐ New Features
🐞 Bug Fixes
📔 Documentation
@ConfigurationPropertiesBinding#45626🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@ahrytsiuk, @izeye, @lhotari, @ngocnhan-tran1996, @nosan, @quaff, @thecooldrop, and @yybmion
v3.4.12Compare Source
🐞 Bug Fixes
@ConditionalOnSingleCandidatewith multiple manually registered singletons [#48117](https:/Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.