Bump controller-tools and its dependencies#38
Merged
briantkennedy merged 1 commit intoGoogleCloudPlatform:mainfrom Jul 17, 2025
Merged
Bump controller-tools and its dependencies#38briantkennedy merged 1 commit intoGoogleCloudPlatform:mainfrom
briantkennedy merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Steps:
1. Bump sigs.k8s.io/controller-tools to v0.18.0
2. go mod tidy
3. make
4. Manual changes to pkg/client/clientset/versioned/typed/networking/v1/fake/fake_gcpgatewaypolicy.go
because GCPGatewayPolicyList has a list of **pointers** in the
Items field (as opposed to GCPTrafficDistributionPolicyList,
for instance).
Contributor
Author
|
/assign @robscott |
Contributor
Author
|
/cc @briantkennedy Could you please have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale:
sigs.k8s.io/controller-tools v0.16.3is outdated, e.g. it does not contain theOptionalOldSelffield in theXValidationtype, which was added in kubernetes-sigs/controller-tools#1150.Most of the changes are created with
make. Please let me know if the repo policy is not to submit such changes.